Skip to content

Commit

Permalink
feat(ci): remove codecov step from tox since performed in GA
Browse files Browse the repository at this point in the history
There is no need to perform the non-working `codecov` step via `tox` since we now have a Github Actions step that performs it.
  • Loading branch information
StephenSorriaux committed Apr 10, 2023
1 parent 33c348b commit aa9ffed
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
- name: Test with tox
run: tox -e ${TOX_VENV}
env:
TOX_VENV: ${{ format('{0}-{1}', matrix.tox-env, 'gevent-eventlet-sasl,codecov') }}
TOX_VENV: ${{ format('{0}-{1}', matrix.tox-env, 'gevent-eventlet-sasl') }}
ZOOKEEPER_VERSION: ${{ matrix.zk-version }}
# TODO: can be removed once tests for ZK 3.4 are removed
ZOOKEEPER_PREFIX: "${{ !contains(matrix.zk-version, '3.4') && 'apache-' || '' }}"
Expand Down
4 changes: 0 additions & 4 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ extras =
sasl: sasl
deps =
sasl: kerberos
codecov: codecov
allowlist_externals =
{toxinidir}/ensure-zookeeper-env.sh
{toxinidir}/init_krb5.sh
Expand All @@ -40,9 +39,6 @@ commands =

[testenv:build]

[testenv:codecov]
commands = - codecov -e TOX_VENV,ZOOKEEPER_VERSION

[testenv:pep8]
basepython = python3
extras = alldeps
Expand Down

0 comments on commit aa9ffed

Please sign in to comment.