Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: make badges link to travis and pypi #528

Merged
merged 2 commits into from
Oct 17, 2018
Merged

docs: make badges link to travis and pypi #528

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efe2975
docs: make badges link to travis and pypi
Oct 8, 2018
c79a152
Try using shields.io badge instead
Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
Kazoo
=====

![Travis Build](https://travis-ci.org/python-zk/kazoo.svg?branch=master)
[![Build Status](https://travis-ci.org/python-zk/kazoo.svg?branch=master)](https://travis-ci.org/python-zk/kazoo)

![Latest Version](https://img.shields.io/pypi/v/kazoo.svg)
[![PyPI version](https://badge.fury.io/py/kazoo.svg)](https://badge.fury.io/py/kazoo)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this last one:

  1. Why switch away from shields.io as the image source?
  2. Why is the URL not pointing directly to PyPI? https://pypi.org/project/kazoo/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Didn't realize that it was a badge service (thought it was maybe just a static image host or something) until you mentioned it.
  2. badge.fury.io automatically redirects to PyPi kazoo. It's just the default way to use them as mentioned in their docs.

I've added a commit to switch back to shields.io and just fix the link instead after reading your comment though.


`kazoo` implements a higher level API to [Apache
Zookeeper](http://zookeeper.apache.org/) for Python clients.
Expand Down