-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin the versions in requirements-dev.txt #16
Conversation
Set pytest-aiohttp to v 0.1.3 Set pytest-asyncio to v 0.5.0
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 6 6
Lines 267 267
Branches 9 9
=====================================
Hits 267 267 Continue to review full report at Codecov.
|
Hm, tests are passing now, but lots of warnings are being generated (see travis log) |
"testing now" where? On master or in this PR? |
Sorry, I don't understand your question.. The tests are failing when using requirements-dev.txt on |
Right, but you mentioned "lots of warnings are being generated" and I checked Travis for this PR and I didn't see any warnings, so I don't know what warnings you're referring to. |
Ah yes, the warnings were here: https://travis-ci.org/python/bedevere/builds/237239682 Setting pytest to 3.0.7 cleared the warnings for this PR. |
The said warnings will be cleared in newer version of pytest-asyncio it seems (unreleased) |
I tweaked the pins to allow for bugfix updates without having to explicitly update the dependencies. Thanks for fixing this! |
Set
pytest-aiohttp
to v 0.1.3Set
pytest-asyncio
to v 0.5.0Set
pytest
to v 3.0.7I tried running the tests locally last night and they failed due to recent updates in pytest-asyncio.
The tests passed again after setting
pytest-asyncio
to version 0.5.0Per @brettcannon's suggestion, also set the version of
pytest-aiohttp
.Edit: A lot of warnings were generated when using
pytest
3.1.0. (travis log) Setting it the version to 3.0.7