Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the versions in requirements-dev.txt #16

Merged
merged 3 commits into from
Jun 2, 2017
Merged

Conversation

Mariatta
Copy link
Member

@Mariatta Mariatta commented May 29, 2017

Set pytest-aiohttp to v 0.1.3
Set pytest-asyncio to v 0.5.0
Set pytest to v 3.0.7

I tried running the tests locally last night and they failed due to recent updates in pytest-asyncio.

The tests passed again after setting pytest-asyncio to version 0.5.0
Per @brettcannon's suggestion, also set the version of pytest-aiohttp.

Edit: A lot of warnings were generated when using pytest 3.1.0. (travis log) Setting it the version to 3.0.7

Set pytest-aiohttp to v 0.1.3 
Set pytest-asyncio to v 0.5.0
@Mariatta Mariatta requested a review from brettcannon May 29, 2017 17:02
@codecov
Copy link

codecov bot commented May 29, 2017

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #16   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         267    267           
  Branches        9      9           
=====================================
  Hits          267    267

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e5526...1153e05. Read the comment docs.

@Mariatta
Copy link
Member Author

Hm, tests are passing now, but lots of warnings are being generated (see travis log)

@Mariatta Mariatta changed the title Pin the versions of pytest-aiohttp and pytest-asyncio Pin the versions in requirements-dev.txt May 30, 2017
@brettcannon
Copy link
Member

"testing now" where? On master or in this PR?

@Mariatta
Copy link
Member Author

Sorry, I don't understand your question..

The tests are failing when using requirements-dev.txt on master branch.
They pass again when using the versions specified in this PR.

@brettcannon
Copy link
Member

Right, but you mentioned "lots of warnings are being generated" and I checked Travis for this PR and I didn't see any warnings, so I don't know what warnings you're referring to.

@Mariatta
Copy link
Member Author

Ah yes, the warnings were here: https://travis-ci.org/python/bedevere/builds/237239682
The commit for that is: eb7c3f5

Setting pytest to 3.0.7 cleared the warnings for this PR.

@Mariatta
Copy link
Member Author

Mariatta commented Jun 1, 2017

The said warnings will be cleared in newer version of pytest-asyncio it seems (unreleased)
Thanks to another Python core developer pytest-dev/pytest-asyncio#51 :)

@brettcannon brettcannon merged commit 0b2b897 into master Jun 2, 2017
@brettcannon brettcannon deleted the Mariatta-patch-1 branch June 2, 2017 01:01
@brettcannon
Copy link
Member

I tweaked the pins to allow for bugfix updates without having to explicitly update the dependencies.

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants