Fix blurb import in the runpy interface
#22
Conversation
When `blurb` was being restructured, the import paths moved to deeper levels of the project layout. It was updated in the console scripts so invoking just the `blurb` command worked but `python -m blurb` didn't. This resulted in breaking the MSI installer smoke testing workflow in CPython's CI [[1]]. Blurb's own CI never invokes said interface, so it had no chance of catching the regression. This patch corrects the import but does not make an attempt to improve testing. [1]: python/cpython#121879
This just adds simple `python -m blurb` invocations, nothing fancy.
|
Thank you! |
|
I need this fix to release 3.13.0b4 asap. Any chance of a quick push to PyPI? Or should I edit the release scripts to pin to the older version? |
|
I was hoping @hugovk would get to it yesterday, especially since publishing has been automated recently, so it should be a few button clicks mostly… |
|
Looks like we're delaying the release by another day for other reasons, so slightly less of a hurry. But if it's not up by the time we restart builds I'll add a pin to 1.1.0 in the release scripts. (edit: looks like 1.2.1 is in progress already, so I'm sure it's close) |
|
@zooba FYI, you should be able to cut a release yourself by simply publishing a v1.2.1 @ https://github.com/python/blurb/releases (assuming you have enough privileges) and then, it'll magically appear on PyPI. The TestPyPI release published by merging this PR succeeded, so the release pipeline is healthy: https://github.com/python/blurb/actions/runs/9970205160/job/27548697808 / https://test.pypi.org/project/blurb/1.2.1.dev11/. |
|
I went looking to see if I could hit the button myself, but it looks like Hugo is already working on it through #23, so I'll leave it there for now. |
|
Sure, I figured. Just wanted to spell out how it works right now, just in case. |
|
You should be able to release, instructions in https://github.com/python/blurb/blob/main/RELEASING.md But I'll do it right away. |
|
Blurb 1.2.1 released! |
When
blurbwas being restructured, the import paths moved to deeper levels of the project layout. It was updated in the console scripts so invoking just theblurbcommand worked butpython -m blurbdidn't. This resulted in breaking the MSI installer smoke testing workflow in CPython's CI [1].Blurb's own CI never invokes said interface, so it had no chance of catching the regression.
This patch corrects the import and adds a smoke test-style invocation of the affected interface.