gh-123340: Show string value of IS_OP oparg in dis (#123348)

python · Aug 26, 2024 · 1eed0f9 · 1eed0f9
1 parent 7bd6ebf
commit 1eed0f9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/Lib/dis.py b/Lib/dis.py
@@ -51,6 +51,7 @@
 LOAD_FAST_LOAD_FAST = opmap['LOAD_FAST_LOAD_FAST']
 STORE_FAST_LOAD_FAST = opmap['STORE_FAST_LOAD_FAST']
 STORE_FAST_STORE_FAST = opmap['STORE_FAST_STORE_FAST']
+IS_OP = opmap['IS_OP']
 
 CACHE = opmap["CACHE"]
 
@@ -629,6 +630,8 @@ def get_argval_argrepr(self, op, arg, offset):
                     argrepr = repr(obj)
             elif deop == LOAD_SPECIAL:
                 argrepr = _special_method_names[arg]
+            elif deop == IS_OP:
+                argrepr = 'is not' if argval else 'is'
         return argval, argrepr
 
 def get_instructions(x, *, first_line=None, show_caches=None, adaptive=False):

diff --git a/Lib/test/test_dis.py b/Lib/test/test_dis.py
@@ -2028,6 +2028,15 @@ def f(x, y, z):
         dis.dis(f.__code__, file=output, show_caches=True)
         self.assertIn("L1:", output.getvalue())
 
+    def test_is_op_format(self):
+        output = io.StringIO()
+        dis.dis("a is b", file=output, show_caches=True)
+        self.assertIn("IS_OP                    0 (is)", output.getvalue())
+
+        output = io.StringIO()
+        dis.dis("a is not b", file=output, show_caches=True)
+        self.assertIn("IS_OP                    1 (is not)", output.getvalue())
+
     def test_baseopname_and_baseopcode(self):
         # Standard instructions
         for name, code in dis.opmap.items():

diff --git a/Misc/NEWS.d/next/Library/2024-08-26-19-36-00.gh-issue-123340.mQKI1H.rst b/Misc/NEWS.d/next/Library/2024-08-26-19-36-00.gh-issue-123340.mQKI1H.rst
@@ -0,0 +1 @@
+Show string value of :opcode:`IS_OP` oparg in :mod:`dis` output.