Skip to content

Commit

Permalink
bpo-40791: Make compare_digest more constant-time.
Browse files Browse the repository at this point in the history
The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization.

(This is change #1 from https://bugs.python.org/issue40791 .)
  • Loading branch information
ssbr committed May 27, 2020
1 parent 404b23b commit 3423012
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Modules/_operator.c
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ _tscmp(const unsigned char *a, const unsigned char *b,
volatile const unsigned char *left;
volatile const unsigned char *right;
Py_ssize_t i;
unsigned char result;
volatile unsigned char result;

/* loop count depends on length of b */
length = len_b;
Expand Down

0 comments on commit 3423012

Please sign in to comment.