Address review comments

python · Aug 14, 2024 · 44eb38f · 44eb38f
1 parent 0b670ac
commit 44eb38f
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 14 deletions.
diff --git a/Include/internal/pycore_uop_ids.h b/Include/internal/pycore_uop_ids.h
diff --git a/Include/internal/pycore_uop_metadata.h b/Include/internal/pycore_uop_metadata.h
diff --git a/Python/bytecodes.c b/Python/bytecodes.c
@@ -156,7 +156,7 @@ dummy_func(
             }
         }
 
-        op(_CHECK_PERIODIC_NOT_YIELD_FROM, (--)) {
+        op(_CHECK_PERIODIC_IF_NOT_YIELD_FROM, (--)) {
             if ((oparg & RESUME_OPARG_LOCATION_MASK) < RESUME_AFTER_YIELD_FROM) {
                 _Py_CHECK_EMSCRIPTEN_SIGNALS_PERIODICALLY();
                 QSBR_QUIESCENT_STATE(tstate); \
@@ -179,7 +179,7 @@ dummy_func(
             if (tstate->tracing == 0) {
                 uintptr_t global_version = _Py_atomic_load_uintptr_relaxed(&tstate->eval_breaker) & ~_PY_EVAL_EVENTS_MASK;
                 uintptr_t code_version = FT_ATOMIC_LOAD_UINTPTR_ACQUIRE(_PyFrame_GetCode(frame)->_co_instrumentation_version);
-                if (code_version != global_version && tstate->tracing == 0) {
+                if (code_version != global_version) {
                     int err = _Py_Instrument(_PyFrame_GetCode(frame), tstate->interp);
                     if (err) {
                         ERROR_NO_POP();
@@ -193,7 +193,7 @@ dummy_func(
         macro(RESUME) =
             _MAYBE_INSTRUMENT +
             _QUICKEN_RESUME +
-            _CHECK_PERIODIC_NOT_YIELD_FROM;
+            _CHECK_PERIODIC_IF_NOT_YIELD_FROM;
 
         inst(RESUME_CHECK, (--)) {
 #if defined(__EMSCRIPTEN__)
@@ -220,7 +220,7 @@ dummy_func(
 
         macro(INSTRUMENTED_RESUME) =
             _MAYBE_INSTRUMENT +
-            _CHECK_PERIODIC_NOT_YIELD_FROM +
+            _CHECK_PERIODIC_IF_NOT_YIELD_FROM +
             _MONITOR_RESUME;
 
         pseudo(LOAD_CLOSURE, (-- unused)) = {

diff --git a/Python/executor_cases.c.h b/Python/executor_cases.c.h
diff --git a/Python/generated_cases.c.h b/Python/generated_cases.c.h
diff --git a/Python/optimizer_cases.c.h b/Python/optimizer_cases.c.h