Skip to content

Commit

Permalink
Address review
Browse files Browse the repository at this point in the history
  • Loading branch information
sobolevn committed Sep 11, 2023
1 parent fe0dad3 commit 90066fb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
5 changes: 2 additions & 3 deletions Tools/wasm/mypy.ini
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ python_version = 3.8
strict = True
enable_error_code = truthy-bool,ignore-without-code

# except for a few settings that can't yet be enabled:
warn_return_any = False
warn_unreachable = False
# except for incomplete defs, which are useful for module authors:
disallow_incomplete_defs = False
5 changes: 3 additions & 2 deletions Tools/wasm/wasm_assets.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import sys
import sysconfig
import zipfile
from typing import Dict
from typing import Dict, cast

# source directory
SRCDIR = pathlib.Path(__file__).parent.parent.parent.absolute()
Expand Down Expand Up @@ -111,7 +111,8 @@ def get_builddir(args: argparse.Namespace) -> pathlib.Path:

def get_sysconfigdata(args: argparse.Namespace) -> pathlib.Path:
"""Get path to sysconfigdata relative to build root"""
data_name = sysconfig._get_sysconfigdata_name() # type: ignore[attr-defined]
assert isinstance(args.builddir, pathlib.Path)
data_name: str = sysconfig._get_sysconfigdata_name() # type: ignore[attr-defined]
if not data_name.startswith(SYSCONFIG_NAMES):
raise ValueError(
f"Invalid sysconfig data name '{data_name}'.", SYSCONFIG_NAMES
Expand Down

0 comments on commit 90066fb

Please sign in to comment.