Skip to content

Commit

Permalink
Swap 'if' branches so content matches to condition in importlib examp…
Browse files Browse the repository at this point in the history
…le (GH-14947)

Prior to this change the guard on an 'elif' used an assignment expression whose value was used in a later 'else' block, causing some confusion for people.

(Discussion on Twitter: https://twitter.com/brettsky/status/1153861041068994566.)

Automerge-Triggered-By: @brettcannon
(cherry picked from commit 544fa15)

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
  • Loading branch information
miss-islington and uranusjr authored Jul 25, 2019
1 parent 25cb4fd commit c594c27
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Doc/library/importlib.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1640,14 +1640,14 @@ import, then you should use :func:`importlib.util.find_spec`.

if name in sys.modules:
print(f"{name!r} already in sys.modules")
elif (spec := importlib.util.find_spec(name)) is None:
print(f"can't find the {name!r} module")
else:
elif (spec := importlib.util.find_spec(name)) is not None:
# If you chose to perform the actual import ...
module = importlib.util.module_from_spec(spec)
sys.modules[name] = module
spec.loader.exec_module(module)
print(f"{name!r} has been imported")
else:
print(f"can't find the {name!r} module")


Importing a source file directly
Expand Down

0 comments on commit c594c27

Please sign in to comment.