Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_check_c_globals to not need distutils & reenable it #100237

Closed
encukou opened this issue Dec 14, 2022 · 1 comment · Fixed by #102506
Closed

Update test_check_c_globals to not need distutils & reenable it #100237

encukou opened this issue Dec 14, 2022 · 1 comment · Fixed by #102506

Comments

@encukou
Copy link
Member

encukou commented Dec 14, 2022

distutils was removed from 3.12, as per PEP 632.
test_check_c_globals, which uses it, was disabled. It should be updated to not need distutils.

See #92584
@encukou encukou added the type-bug An unexpected behavior, bug, or error label Dec 14, 2022
@AlexWaygood AlexWaygood changed the title Update test_check_c_globals no not need distutils & reenable it Update test_check_c_globals to not need distutils & reenable it Dec 14, 2022
@encukou encukou removed the type-bug An unexpected behavior, bug, or error label Dec 14, 2022
@AlexWaygood AlexWaygood mentioned this issue Mar 8, 2023
Merged
@ericsnowcurrently ericsnowcurrently mentioned this issue Mar 8, 2023
Merged
@ericsnowcurrently
Copy link
Member

I'm taking care of this via gh-102506.

@ericsnowcurrently ericsnowcurrently mentioned this issue Mar 8, 2023
Closed
ericsnowcurrently added a commit that referenced this issue Mar 14, 2023
@ericsnowcurrently
gh-81057: Add a CI Check for New Unsupported C Global Variables (gh-1…
1ff81c0 
…02506)

This will keep us from adding new unsupported (i.e. non-const) C global variables, which would break interpreter isolation.

FYI, historically it is very uncommon for new global variables to get added. Furthermore, it is rare for new code to break the c-analyzer. So the check should almost always pass unnoticed.

Note that I've removed test_check_c_globals. A test wasn't a great fit conceptually and was super slow on debug builds. A CI check is a better fit.

This also resolves gh-100237.

#81057
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@ericsnowcurrently @Fidget-Spinner
pythongh-81057: Add a CI Check for New Unsupported C Global Variables (…
038b67c 
…pythongh-102506)

This will keep us from adding new unsupported (i.e. non-const) C global variables, which would break interpreter isolation.

FYI, historically it is very uncommon for new global variables to get added. Furthermore, it is rare for new code to break the c-analyzer. So the check should almost always pass unnoticed.

Note that I've removed test_check_c_globals. A test wasn't a great fit conceptually and was super slow on debug builds. A CI check is a better fit.

This also resolves pythongh-100237.

python#81057
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@ericsnowcurrently @warsaw
pythongh-81057: Add a CI Check for New Unsupported C Global Variables (…
e20008f 
…pythongh-102506)

This will keep us from adding new unsupported (i.e. non-const) C global variables, which would break interpreter isolation.

FYI, historically it is very uncommon for new global variables to get added. Furthermore, it is rare for new code to break the c-analyzer. So the check should almost always pass unnoticed.

Note that I've removed test_check_c_globals. A test wasn't a great fit conceptually and was super slow on debug builds. A CI check is a better fit.

This also resolves pythongh-100237.

python#81057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-81057: Add a CI Check for New Unsupported C Global Variables ericsnowcurrently/cpython
2 participants
@encukou @ericsnowcurrently