Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise get_io_state() #101469

Closed
erlend-aasland opened this issue Jan 31, 2023 · 0 comments · Fixed by #101470
Closed

Optimise get_io_state() #101469

erlend-aasland opened this issue Jan 31, 2023 · 0 comments · Fixed by #101470
Labels
extension-modules C modules in the Modules dir performance Performance or resource usage

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jan 31, 2023 •
edited by bedevere-bot
Loading

The _io extension module is required to bootstrap Python, so we can safely use internal C APIs. We should use static inlined _PyModule_GetState instead of the slower PyModule_GetState.

Linked PRs
@erlend-aasland erlend-aasland added performance Performance or resource usage extension-modules C modules in the Modules dir labels Jan 31, 2023
@bedevere-bot bedevere-bot mentioned this issue Jan 31, 2023
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jan 31, 2023
@erlend-aasland
pythongh-101469: Optimise get_io_state() by using _PyModule_GetState()
bd4f58a
@erlend-aasland erlend-aasland linked a pull request Jan 31, 2023 that will close this issue
gh-101469: Optimise get_io_state() by using _PyModule_GetState() #101470
Merged
miss-islington pushed a commit that referenced this issue Jan 31, 2023
@erlend-aasland
gh-101469: Optimise get_io_state() by using _PyModule_GetState() (GH-…
f80db6c 
…101470)

Automerge-Triggered-By: GH:erlend-aasland
carljm added a commit to carljm/cpython that referenced this issue Jan 31, 2023
@carljm
Merge branch 'main' into inlinecomp2
db208d5 
* main:
  pythonGH-100288: Skip extra work when failing to specialize LOAD_ATTR (pythonGH-101354)
  pythongh-101409: Improve generated clinic code for self type checks (python#101411)
  pythongh-98831: rewrite BEFORE_ASYNC_WITH and END_ASYNC_FOR in the instruction definition DSL (python#101458)
  pythongh-101469: Optimise get_io_state() by using _PyModule_GetState() (pythonGH-101470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension-modules C modules in the Modules dir performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-101469: Optimise get_io_state() by using _PyModule_GetState() erlend-aasland/cpython
1 participant
@erlend-aasland