Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refleak after new OrderedDict repr #101747

Closed
sobolevn opened this issue Feb 9, 2023 · 1 comment
Closed

Refleak after new OrderedDict repr #101747

sobolevn opened this issue Feb 9, 2023 · 1 comment
Assignees
@sobolevn
Labels
type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Feb 9, 2023 •
edited by bedevere-bot
Loading

It is reported by @corona10 that after 790ff6b we have a new refleak:

  • test_ordered_dict
  • test_pprint
  • test_trace

Looks like dcopy = PyDict_Copy((PyObject *)self); is created, but never freed :(

PR is on its way.

Linked PRs
@sobolevn sobolevn added the type-bug An unexpected behavior, bug, or error label Feb 9, 2023
@sobolevn sobolevn self-assigned this Feb 9, 2023
@sobolevn
Copy link
Member Author

sobolevn commented Feb 9, 2023

Local repro: ./python.exe -m test -v test_ordered_dict -R 3:3

test_ordered_dict leaked [1196, 1194, 1196] references, sum=3586
test_ordered_dict leaked [203, 202, 203] memory blocks, sum=608
test_ordered_dict failed (reference leak)

== Tests result: FAILURE ==

1 test failed:
    test_ordered_dict

sobolevn added a commit to sobolevn/cpython that referenced this issue Feb 9, 2023
@sobolevn
pythongh-101747: Fix refleak in new OrderedDict repr
f8adfe9
@bedevere-bot bedevere-bot mentioned this issue Feb 9, 2023
Merged
@sobolevn sobolevn mentioned this issue Feb 9, 2023
Closed
rhettinger pushed a commit that referenced this issue Feb 10, 2023
@sobolevn
gh-101747: Fix refleak in new OrderedDict repr (GH-101748)
34c50ce
@rhettinger rhettinger closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
@rhettinger rhettinger reopened this Feb 10, 2023
carljm added a commit to carljm/cpython that referenced this issue Feb 10, 2023
@carljm
Merge branch 'main' into inlinecomp2
add772e 
* main:
  Fix some typos in asdl_c.py (pythonGH-101757)
  pythongh-101747: Fix refleak in new `OrderedDict` repr (pythonGH-101748)
  pythongh-101430: Update tracemalloc to handle presize properly. (pythongh-101745)
  pythonGH-101228: Fix typo in docstring for read method of `_io.TextIOWrapper` class (python#101227)
  Fix typo in `test_fstring.py` (python#101600)
  pythongh-101726: Update the OpenSSL version to 1.1.1t (pythonGH-101727)
  pythongh-101283: Fix 'versionchanged' for the shell=True fallback on Windows in 3.12 (pythonGH-101728)
  LibFFI build requires x64 Cygwin, and skip the ARM build (pythonGH-101743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhettinger @sobolevn