Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several minor bugs in test_typing highlighted by pyflakes #102444

Closed
AlexWaygood opened this issue Mar 5, 2023 · 0 comments
Closed

Several minor bugs in test_typing highlighted by pyflakes #102444

AlexWaygood opened this issue Mar 5, 2023 · 0 comments
Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error

Comments

@AlexWaygood
Copy link
Member

AlexWaygood commented Mar 5, 2023 •
edited by bedevere-bot
Loading

Following #102437 by @JosephSBoyle, I tried running pyflakes on test_typing.py. It highlighted:

  • Another instance where a test isn't testing what it was meant to be testing
  • An instance where a test is entirely duplicated
  • Several unused imports or variables.

Linked PRs
@AlexWaygood AlexWaygood added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir topic-typing labels Mar 5, 2023
AlexWaygood added a commit to AlexWaygood/cpython that referenced this issue Mar 5, 2023
@AlexWaygood
pythongh-102444: Fix minor bugs in test_typing highlighted by pyflakes
95a7747
This was referenced Mar 5, 2023
Merged
Merged
AlexWaygood added a commit that referenced this issue Mar 5, 2023
@AlexWaygood
gh-102444: Fix minor bugs in test_typing highlighted by pyflakes (#…
96e1022 
…102445)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 5, 2023
@AlexWaygood @miss-islington
pythongh-102444: Fix minor bugs in test_typing highlighted by pyfla…
8ed1e3a 
…kes (pythonGH-102445)

(cherry picked from commit 96e1022)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit to AlexWaygood/cpython that referenced this issue Mar 5, 2023
@AlexWaygood
[3.10] pythongh-102444: Fix minor bugs in test_typing highlighted b…
26f1961 
…y pyflakes (python#102445)

(cherry picked from commit 96e1022)
@bedevere-bot bedevere-bot mentioned this issue Mar 5, 2023
Merged
miss-islington added a commit that referenced this issue Mar 5, 2023
@miss-islington @AlexWaygood
gh-102444: Fix minor bugs in test_typing highlighted by pyflakes (G…
a7ec32e 
…H-102445)

(cherry picked from commit 96e1022)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this issue Mar 5, 2023
@AlexWaygood
[3.10] gh-102444: Fix minor bugs in test_typing highlighted by pyfl…
f5280e2 
…akes (#102445) (#102452)

(cherry picked from commit 96e1022)
hugovk pushed a commit to hugovk/cpython that referenced this issue Mar 6, 2023
@AlexWaygood @hugovk
pythongh-102444: Fix minor bugs in test_typing highlighted by pyfla…
30b2feb 
…kes (python#102445)
carljm added a commit to carljm/cpython that referenced this issue Mar 6, 2023
@carljm
Merge branch 'main' into nodeaddict
33dda2a 
* main: (21 commits)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472)
  pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455)
  pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467)
  pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667)
  pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664)
  pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665)
  pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445)
  pythonGH-102341: Improve the test function for pow (python#102342)
  Fix unused classes in a typing test (pythonGH-102437)
  pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318)
  pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426)
  Move around example in to_bytes() to avoid confusion (python#101595)
  pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421)
  pythongh-96821: Add config option `--with-strict-overflow` (python#96823)
  pythongh-101992: update pstlib module documentation (python#102133)
  pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699)
  pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417)
  pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303)
  pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180)
  pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896)
  ...
carljm added a commit to carljm/cpython that referenced this issue Mar 7, 2023
@carljm
Merge branch 'main' into inlinecomp2
ecb313c 
* main: (37 commits)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472)
  pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455)
  pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467)
  pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667)
  pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664)
  pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665)
  pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445)
  pythonGH-102341: Improve the test function for pow (python#102342)
  Fix unused classes in a typing test (pythonGH-102437)
  pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318)
  pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426)
  Move around example in to_bytes() to avoid confusion (python#101595)
  pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421)
  pythongh-96821: Add config option `--with-strict-overflow` (python#96823)
  pythongh-101992: update pstlib module documentation (python#102133)
  pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699)
  pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417)
  pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303)
  pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180)
  pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896)
  ...
@AlexWaygood AlexWaygood mentioned this issue Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir topic-typing type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexWaygood