-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 688: Crash if __release_buffer__
is called while an exception is active
#104371
Labels
Comments
JelleZijlstra
added
type-bug
An unexpected behavior, bug, or error
release-blocker
labels
May 10, 2023
JelleZijlstra
added a commit
to JelleZijlstra/cpython
that referenced
this issue
May 11, 2023
kumaraditya303
added a commit
that referenced
this issue
May 12, 2023
…tive (#104378) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
github-project-automation
bot
moved this from Todo
to Done
in Release and Deferred blockers 🚫
May 12, 2023
kumaraditya303
added a commit
that referenced
this issue
May 12, 2023
carljm
added a commit
to carljm/cpython
that referenced
this issue
May 12, 2023
* main: pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422) pythonGH-104371: check return value of calling `mv.release` (python#104417) pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416) pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863) pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387) pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403) pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390) pythongh-101819: Prepare _io._IOBase for module state (python#104386) pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414) Fix refleak in `super_descr_get` (python#104408) pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700) pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294) pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378) pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394) pythongh-104392: Remove _paramspec_tvars from typing (python#104393) pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397) pythongh-99108: Refresh HACL* from upstream (python#104401) pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In a debug build this crashes with
Assertion failed: (!PyErr_Occurred()), function _PyType_Lookup, file typeobject.c, line 4707.
Reported by @chilaxan. I'll work on a fix later today.
Most likely, the fix will be to call
PyErr_Fetch
/PyErr_Restore
around calls to Python__release_buffer__
methods.Linked PRs
mv.release
#104417The text was updated successfully, but these errors were encountered: