-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_venv spams our AddressSanitizer CI with 5mb of test logs #104839
Labels
type-bug
An unexpected behavior, bug, or error
Comments
Thank you for diagnosing the test doing this. |
gpshead
added a commit
to gpshead/cpython
that referenced
this issue
May 26, 2023
Pass any ASAN_OPTIONS environment variable through to the child process so that leak sanitizer being disabled on our CI and buildbots stays true in the children.
gpshead
added a commit
that referenced
this issue
May 27, 2023
Pass any ASAN_OPTIONS environment variable through to the child process so that leak sanitizer being disabled on our CI and buildbots stays true in the children.
gpshead
added a commit
that referenced
this issue
May 27, 2023
…#105006) gh-104839: Prevent test_venv AddressSanitizer spam (GH-105005) Pass any ASAN_OPTIONS environment variable through to the child process so that leak sanitizer being disabled on our CI and buildbots stays true in the children. (cherry picked from commit a17f160) Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
test_venv
is spamming our AddressSanitizer CI runs with 5mb (50000 lines) of LeakSanitizer reports. Likely because it does not allow theASAN_OPTIONS
environment variable setting through to child Python processes it spawns.if the test isn't useful for AddressSanitizer we should just skip it on ASAN runs. otherwise we need to make sure the relevant environment is plumbed through.
It makes looking at AddressSanitizer logs from Github's CI interface in a browser next to impossible to use. You have to download the logs to be able to make sense out of them.
Linked PRs
The text was updated successfully, but these errors were encountered: