Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_gzip failure under WASI #106160

Closed
brettcannon opened this issue Jun 27, 2023 · 0 comments
Closed

Fix test_gzip failure under WASI #106160

brettcannon opened this issue Jun 27, 2023 · 0 comments
Assignees
@brettcannon
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes OS-wasi tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@brettcannon
Copy link
Member

brettcannon commented Jun 27, 2023 •
edited by bedevere-bot
Loading

1858db7 introduced a dependency on zlib in test_gzip (see https://buildbot.python.org/all/#/builders/1046/builds/2315 for the first failure), but zlib is not guaranteed to exist.

/cc @Yhg1s

Linked PRs
@brettcannon brettcannon added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Jun 27, 2023
@brettcannon brettcannon self-assigned this Jun 27, 2023
brettcannon referenced this issue Jun 27, 2023
@Yhg1s
GH-105808: Fix a regression introduced in GH-101251 (#105910)
1858db7 
Fix a regression introduced in GH-101251, causing GzipFile.flush() to
not flush the compressor (nor pass along the zip_mode argument).
@brettcannon brettcannon added 3.12 bugs and security fixes 3.13 bugs and security fixes labels Jun 27, 2023
@bedevere-bot bedevere-bot mentioned this issue Jun 28, 2023
Merged
Yhg1s added a commit that referenced this issue Jun 28, 2023
@Yhg1s
GH-106160: Fix test_gzip failing under WASI, which does not have zlib. (
161012f 
#106167)

Fix test_gzip's failure under WASI, which does not have zlib, by using
test.support.import_helper.import_module to import zlib. (gzip
unconditionally imports zlib, so this does not cause any new skips.)
@bedevere-bot bedevere-bot mentioned this issue Jun 28, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 28, 2023
@Yhg1s @miss-islington
pythonGH-106160: Fix test_gzip failing under WASI, which does not hav…
a7fa8d5 
…e zlib. (pythonGH-106167)

Fix test_gzip's failure under WASI, which does not have zlib, by using
test.support.import_helper.import_module to import zlib. (gzip
unconditionally imports zlib, so this does not cause any new skips.)
(cherry picked from commit 161012f)

Co-authored-by: T. Wouters <thomas@python.org>
kumaraditya303 pushed a commit that referenced this issue Jun 28, 2023
@miss-islington @Yhg1s
[3.12] GH-106160: Fix test_gzip failing under WASI, which does not ha…
442f5ec 
…ve zlib. (GH-106167) (#106170)

GH-106160: Fix test_gzip failing under WASI, which does not have zlib. (GH-106167)

Fix test_gzip's failure under WASI, which does not have zlib, by using
test.support.import_helper.import_module to import zlib. (gzip
unconditionally imports zlib, so this does not cause any new skips.)
(cherry picked from commit 161012f)

Co-authored-by: T. Wouters <thomas@python.org>
@github-project-automation github-project-automation bot moved this from Todo to Done in WASI to tier 2 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettcannon brettcannon

Labels
3.12 bugs and security fixes 3.13 bugs and security fixes OS-wasi tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
No open projects
WASI to tier 2
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @AlexWaygood