Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run plausible analytics out of docs.python.org #107136

Closed
JulienPalard opened this issue Jul 23, 2023 · 2 comments
Closed

Don't run plausible analytics out of docs.python.org #107136

JulienPalard opened this issue Jul 23, 2023 · 2 comments
Assignees
Labels
docs Documentation in the Doc dir

Comments

@JulienPalard
Copy link
Member

JulienPalard commented Jul 23, 2023

Documentation

Since e8ab009, an HTTP request to plausible.io is triggered even for local builds.

So I just triggered the tracker with a local build just to check a PR (this is how I discovered it, by seeing uBlock Origin telling me it blocked it).

I don't feel that's OK as it means that Linux packages containing the Python doc, like python3-doc will embed the tracker too (or every distrib will take the pain to remove it...).

I think e8ab009 should be reverted and maybe implemented on docsbuild-scripts, or at least be made optional (using an environment flag?) and disabled by default so we could enable it in docsbuild-script.

Linked PRs

@JulienPalard JulienPalard added the docs Documentation in the Doc dir label Jul 23, 2023
@hugovk
Copy link
Member

hugovk commented Aug 2, 2023

Thanks for raising this, I suggest we let the trial run to its end (there are 8 days left), revert, and then look into those options if we continue using it.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 22, 2023
(cherry picked from commit fc23f34)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 22, 2023
(cherry picked from commit fc23f34)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
ambv pushed a commit that referenced this issue Aug 23, 2023
)

(cherry picked from commit fc23f34)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
ambv pushed a commit that referenced this issue Aug 23, 2023
)

(cherry picked from commit fc23f34)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk
Copy link
Member

hugovk commented Nov 10, 2023

PRs were merged, let's close this now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

No branches or pull requests

2 participants