Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary comment about increasing the reference count in usage of Py_None #107955

Closed
Eclips4 opened this issue Aug 14, 2023 · 6 comments
Closed

Comments

@Eclips4
Copy link
Member

Eclips4 commented Aug 14, 2023

After merging of #19474 this comment looks unnecessary:

Don't forget to apply Py_INCREF() when returning this value!!!

Linked PRs

@Eclips4
Copy link
Member Author

Eclips4 commented Aug 14, 2023

cc @eduardo-elizondo

@corona10
Copy link
Member

Do you want to send a PR to update the comment?

@brandonardenwalli
Copy link
Contributor

If possible, I can do the change too? This looks to be fairly simple and I think I should be able to do.

@Eclips4
Copy link
Member Author

Eclips4 commented Aug 15, 2023

If possible, I can do the change too? This looks to be fairly simple and I think I should be able to do.

Go ahead =)

@brandonardenwalli
Copy link
Contributor

Great, I will make fix soon!

@eduardo-elizondo
Copy link
Contributor

Good catch, and yeah, as @corona10 mentioned, feel free to create a PR to clean it up 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants