Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run test_posix on Windows #111912

Closed
serhiy-storchaka opened this issue Nov 9, 2023 · 1 comment
Closed

Run test_posix on Windows #111912

serhiy-storchaka opened this issue Nov 9, 2023 · 1 comment
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Nov 9, 2023 •
edited by bedevere-app bot
Loading

When I searched for a place for tests for gh-111841, I have found that they already exist, but in test_posix which is skipped on Windows.

The simplest way is to make test_posix running on Windows. It turned out that most tests are already compatible with Windows, except this test and yet one test that tests for Posix-specific constants.

Linked PRs
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir 3.12 bugs and security fixes 3.13 bugs and security fixes labels Nov 9, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 9, 2023
@serhiy-storchaka
pythongh-111912: Run test_posix on Windows
c274a06
@bedevere-app bedevere-app bot mentioned this issue Nov 9, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Nov 10, 2023
@serhiy-storchaka
gh-111912: Run test_posix on Windows (GH-111913)
64fea32
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 10, 2023
@serhiy-storchaka @miss-islington
pythongh-111912: Run test_posix on Windows (pythonGH-111913)
4960370 
(cherry picked from commit 64fea32)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Nov 10, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 10, 2023
@serhiy-storchaka @miss-islington
pythongh-111912: Run test_posix on Windows (pythonGH-111913)
411096c 
(cherry picked from commit 64fea32)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Nov 10, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Nov 10, 2023
@miss-islington @serhiy-storchaka
[3.11] gh-111912: Run test_posix on Windows (GH-111913) (GH-111954)
e433785 
(cherry picked from commit 64fea32)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this issue Nov 10, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-111912: Run test_posix on Windows (GH-111913) (GH-111953)
41b2d8c 
(cherry picked from commit 64fea32)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@hugovk
Copy link
Member

hugovk commented Dec 11, 2023

Fixed and backported, looks like we can close this. Thanks!

@hugovk hugovk closed this as completed Dec 11, 2023
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-111912: Run test_posix on Windows (pythonGH-111913)
fc28e6b
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-111912: Run test_posix on Windows (pythonGH-111913)
c70b20e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hugovk @serhiy-storchaka