Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests for shutil.make_archive() #118148

Closed
serhiy-storchaka opened this issue Apr 22, 2024 · 0 comments
Closed

Improve tests for shutil.make_archive() #118148

serhiy-storchaka opened this issue Apr 22, 2024 · 0 comments
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Apr 22, 2024 •
edited by bedevere-app bot
Loading

While working on my idea for #80145, I noticed that not all combinations of None and not-None root_dir and base_dir are tested. The proposed PR expands the tests.

Linked PRs
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir needs backport to 3.12 bug and security fixes labels Apr 22, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Apr 22, 2024
@serhiy-storchaka
pythongh-118148: Improve tests for shutil.make_archive()
63ea548
@bedevere-app bedevere-app bot mentioned this issue Apr 22, 2024
Merged
@serhiy-storchaka serhiy-storchaka added 3.12 bugs and security fixes 3.13 bugs and security fixes and removed needs backport to 3.12 bug and security fixes labels Apr 22, 2024
serhiy-storchaka added a commit that referenced this issue Apr 22, 2024
@serhiy-storchaka
gh-118148: Improve tests for shutil.make_archive() (GH-118149)
287d939
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 22, 2024
@serhiy-storchaka @miss-islington
pythongh-118148: Improve tests for shutil.make_archive() (pythonGH-11…
0457a7e 
…8149)

(cherry picked from commit 287d939)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Apr 22, 2024
Merged
serhiy-storchaka added a commit that referenced this issue Apr 22, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-118148: Improve tests for shutil.make_archive() (GH-118149) (…
312d819 
…GH-118151)

(cherry picked from commit 287d939)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka