Incorrect case string in configure script

[allsey87]

Bug report

Bug description:

I think this:

cpython/configure

Line 12895 in fd104df

Emscripten|WASI)

Should be: Emscripten*|WASI*

I could be wrong, but I think this will never be matched otherwise since even if ac_sys_release is empty, we would be trying to match Emscripten against Emscripten/

CPython versions tested on:

CPython main branch

Operating systems tested on:

Other

Linked PRs

• gh-120154: Fix Emscripten/WASI pattern in case statement for LDSHARED #120173
• [3.13] gh-120154: Fix Emscripten/WASI pattern in case statement for LDSHARED (GH-120173) #120199
• [3.12] gh-120154: Fix Emscripten/WASI pattern in case statement for LDSHARED… #120204
• [3.12] gh-120154: On WASI, don't build test modules #120309

[allsey87]

I think the only reason why this hasn't been an issue/picked up before is that usually, for Emscripten builds, emconfigure is executed instead of configure which sets LDSHARED as an environment variable, causing the entire block to be bypassed.

[allsey87]

I can confirm that patching configure enabled me to move forwards. The values in the resulting Makefile now looks closer to what is generated in the Pyodide project with an extra -shared argument passed to emcc.

[erlend-aasland]

Thanks for the report! It sounds like you have a patch ready; would you like to open a PR?

[erlend-aasland]

Thanks for the report and the fix, @allsey87!

[vstinner]

@allsey87: Thanks for signing again the CLA with your second email address.

[encukou]

This broke the stable buildbot wasm32-wasi Non-Debug 3.12, see e.g. here.

[allsey87]

Are you sure it was this commit? The error that you are getting sounds unrelated to this change:

wasm-ld: error: Modules/_testimportmultiple.o: relocation R_WASM_MEMORY_ADDR_SLEB cannot be used against symbol `_testimportmultiple`; recompile with -fPIC

[vstinner]

This broke the stable buildbot wasm32-wasi Non-Debug 3.12, see e.g. here.

wasm-ld: error: Modules/_testimportmultiple.o: relocation R_WASM_MEMORY_ADDR_SLEB cannot be used against symbol `_testimportmultiple`; recompile with -fPIC
wasm-ld: error: Modules/_testimportmultiple.o: relocation R_WASM_MEMORY_ADDR_SLEB cannot be used against symbol `_foomodule`; recompile with -fPIC
wasm-ld: error: Modules/_testimportmultiple.o: relocation R_WASM_MEMORY_ADDR_SLEB cannot be used against symbol `_barmodule`; recompile with -fPIC

The difference between main and 3.12 is that 3.12 tries to build test modules such as _testimportmultiple.

=> I wrote #120309 to fix the issue: on WASI, no longer build test modules on Python 3.12.

[allsey87]

@vstinner not sure if this relevant, but #120204 did change the flags for the buildbot.

Previously:

checking LDSHARED... 
checking BLDSHARED flags... 
checking CCSHARED... 
checking LINKFORSHARED... 
checking CFLAGSFORSHARED... 

Now:

checking LDSHARED... $(CC) -shared
checking BLDSHARED flags... $(CC) -shared
checking CCSHARED... 
checking LINKFORSHARED... 
checking CFLAGSFORSHARED... 

I think this is correct though, and any build configuration relying on those flags not being set would be the problem.

[hugovk]

Triage: the linked PRs are merged, can this be closed or is there more to do?

[allsey87]

The linked PRs are indeed merged. Closing.