-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve PyBytes_FromStringAndSize
test coverage
#121842
Labels
Comments
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Jul 16, 2024
sobolevn
added a commit
that referenced
this issue
Jul 17, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jul 17, 2024
…honGH-121843) (cherry picked from commit f6c7d8d) Co-authored-by: sobolevn <mail@sobolevn.me>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jul 17, 2024
…honGH-121843) (cherry picked from commit f6c7d8d) Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn
added a commit
that referenced
this issue
Jul 17, 2024
sobolevn
added a commit
that referenced
this issue
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's a fast-path in
PyBytes_FromStringAndSize
that is not covered:cpython/Objects/bytesobject.c
Lines 120 to 124 in 8549559
Here:
cpython/Objects/bytesobject.c
Lines 111 to 124 in 8549559
We don't have test cases for it:
cpython/Lib/test/test_capi/test_bytes.py
Lines 49 to 65 in 8549559
I propose adding:
So we would have better C coverage stats. It won't hurt in any case, even if this path is removed some day.
Linked PRs
PyBytes_FromStringAndSize
#121843PyBytes_FromStringAndSize
(GH-121843) #121893PyBytes_FromStringAndSize
(GH-121843) #121894The text was updated successfully, but these errors were encountered: