-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: inconsistent open and io.open audit-event parameters #121874
Comments
My tools tell me, that the issue goes away, when both builds happen in 1-core-VMs, so it might be a race-condition. |
Sounds like something to report to Sphinx. |
bmwiedemann
added a commit
to bmwiedemann/cpython
that referenced
this issue
Jul 17, 2024
as in Doc/library/io.rst: .. audit-event:: open path,mode,flags io.open Doc/library/os.rst: .. audit-event:: open path,mode,flags os.open to avoid triggering a race-condition in Sphinx that causes non-deterministic output. Fixes: python#121874
bmwiedemann
added a commit
to bmwiedemann/cpython
that referenced
this issue
Jul 17, 2024
as in Doc/library/io.rst: .. audit-event:: open path,mode,flags io.open Doc/library/os.rst: .. audit-event:: open path,mode,flags os.open to avoid triggering a race-condition in Sphinx that causes non-deterministic output. See https://reproducible-builds.org/ for why this matters. Fixes: python#121874 This patch was done while working on reproducible builds for openSUSE, sponsored by the NLnet NGI0 fund.
It is probably sphinx-doc/sphinx#2946 = sphinx-doc/sphinx#6714 - open since many years. |
bmwiedemann
added a commit
to bmwiedemann/cpython
that referenced
this issue
Jul 17, 2024
as in Doc/library/functions.rst: .. audit-event:: open file,mode,flags open Doc/library/io.rst: .. audit-event:: open path,mode,flags io.open Doc/library/os.rst: .. audit-event:: open path,mode,flags os.open to avoid triggering a race-condition in Sphinx that causes non-deterministic output. See https://reproducible-builds.org/ for why this matters. Fixes: python#121874 Alternative to: python#121883 This patch was done while working on reproducible builds for openSUSE, sponsored by the NLnet NGI0 fund.
bmwiedemann
added a commit
to bmwiedemann/cpython
that referenced
this issue
Jul 17, 2024
as in Doc/library/io.rst: .. audit-event:: open path,mode,flags io.open Doc/library/os.rst: .. audit-event:: open path,mode,flags os.open to avoid triggering a race-condition in Sphinx that causes non-deterministic output. See https://reproducible-builds.org/ for why this matters. Fixes: python#121874 This patch was done while working on reproducible builds for openSUSE, sponsored by the NLnet NGI0 fund.
serhiy-storchaka
pushed a commit
that referenced
this issue
Jul 18, 2024
Use same names for parameters to avoid triggering a race-condition in Sphinx that causes non-deterministic output.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jul 18, 2024
…honGH-121883) Use same names for parameters to avoid triggering a race-condition in Sphinx that causes non-deterministic output. (cherry picked from commit 24cf867) Co-authored-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jul 18, 2024
…honGH-121883) Use same names for parameters to avoid triggering a race-condition in Sphinx that causes non-deterministic output. (cherry picked from commit 24cf867) Co-authored-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
This was referenced Jul 18, 2024
hugovk
added a commit
that referenced
this issue
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Bug description:
While working on reproducible builds for openSUSE (sponsored by the NLnet NGI0 fund), I found that
our
openSUSE:Factory/python312
doc varied inhtml/library/audit_events.html
in a strange way:According to strace, this file is written by a call to
["sphinx-build", "-b", "html", "-d", "build/doctrees", "-j", "auto", ".", "build/html"]
All build output should be deterministic.
CPython versions tested on:
3.10, 3.11, 3.12
Operating systems tested on:
Linux
Linked PRs
The text was updated successfully, but these errors were encountered: