Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bundled pip to 24.2 #122744

Closed
pradyunsg opened this issue Aug 6, 2024 · 4 comments
Closed

Upgrade bundled pip to 24.2 #122744

pradyunsg opened this issue Aug 6, 2024 · 4 comments
Labels
topic-ensurepip type-feature A feature request or enhancement

Comments

@pradyunsg
Copy link
Member

pradyunsg commented Aug 6, 2024

Feature or enhancement

Proposal:

ensurepip's bundled version of pip gets updated to the current latest 24.2.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

N/A

Linked PRs

@pradyunsg pradyunsg added type-feature A feature request or enhancement topic-ensurepip labels Aug 6, 2024
pradyunsg added a commit to pradyunsg/cpython that referenced this issue Aug 6, 2024
pradyunsg added a commit to pradyunsg/cpython that referenced this issue Aug 6, 2024
pradyunsg added a commit to pradyunsg/cpython that referenced this issue Aug 6, 2024
(cherry picked from commit 40f3095)

Co-authored-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
pradyunsg added a commit to pradyunsg/cpython that referenced this issue Aug 6, 2024
(cherry picked from commit 40f3095)

Co-authored-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
pradyunsg added a commit to pradyunsg/cpython that referenced this issue Aug 6, 2024
Yhg1s pushed a commit that referenced this issue Aug 6, 2024
Co-authored-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
Yhg1s pushed a commit that referenced this issue Aug 6, 2024
(cherry picked from commit 5b8a6c5)

Co-authored-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
Yhg1s pushed a commit that referenced this issue Aug 6, 2024
(cherry picked from commit 5b8a6c5)

Co-authored-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
@hugovk
Copy link
Member

hugovk commented Aug 6, 2024

And all merged :)

@hugovk hugovk closed this as completed Aug 6, 2024
@neonene
Copy link
Contributor

neonene commented Aug 7, 2024

test_venv has been failed on the buildbots below since 5b8a6c5 and the backports.

  • buildbot/AMD64 RHEL7 *
  • buildbot/PPC64LE RHEL7 *
  • buildbot/x86-64 MacOS Intel ASAN NoGIL
=====================================================================
FAIL: test_with_pip (test.test_venv.EnsurePipTest.test_with_pip)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_venv.py", line 923, in test_with_pip
self.do_test_with_pip(False)
~~~~~~~~~~~~~~~~~~~~~^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_venv.py", line 889, in do_test_with_pip
self.assertEqual(err.rstrip(), "")
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
AssertionError: 'WARNING: Disabling truststore since ssl support is missing' != ''
- WARNING: Disabling truststore since ssl support is missing

@hugovk
Copy link
Member

hugovk commented Aug 7, 2024

Maybe we should skip this test when ssl is missing?

cc @sethmlarson

@encukou
Copy link
Member

encukou commented Aug 7, 2024

We can ignore the message if it's expected; there's code for another warning already: #122776

The question for @sethmlarson or pip maintainers is, will pip stick with this wording?
It seems the user-facing name of the feature is Using system certificate stores.
IMO, it's not very clear whether pip falls back to certifi in this case (or what certifi is, for that matter).

@encukou encukou reopened this Aug 7, 2024
brandtbucher pushed a commit to brandtbucher/cpython that referenced this issue Aug 7, 2024
Co-authored-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 8, 2024
…ythonGH-122776)

(cherry picked from commit 0d9c123)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 8, 2024
…ythonGH-122776)

(cherry picked from commit 0d9c123)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this issue Aug 9, 2024
…GH-122776) (GH-122823)

(cherry picked from commit 0d9c123)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this issue Aug 9, 2024
…GH-122776) (GH-122822)

(cherry picked from commit 0d9c123)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@encukou encukou closed this as completed Aug 9, 2024
blhsing pushed a commit to blhsing/cpython that referenced this issue Aug 22, 2024
Co-authored-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-ensurepip type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants