You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a common pattern for calls. The stack looks like this: funcself_or_nullargs[oparg] and if self_or_null is not NULL we merge it into the args array. This is error prone however as the code generator thinks self_or_null is a discrete scalar, not part of an array.
We have specific code to workaround this, but I'm not sure that there are lurking bugs.
We should, instead, define self_or_null as an array of size 1. This tells the code generator that it is an array and must be in memory, not a register.
As well as causing issues now, this is necessary for #120024 and #121459.
Bug report
We have a common pattern for calls. The stack looks like this:
func
self_or_null
args[oparg]
and ifself_or_null
is notNULL
we merge it into theargs
array. This is error prone however as the code generator thinksself_or_null
is a discrete scalar, not part of an array.We have specific code to workaround this, but I'm not sure that there are lurking bugs.
We should, instead, define
self_or_null
as an array of size 1. This tells the code generator that it is an array and must be in memory, not a register.As well as causing issues now, this is necessary for #120024 and #121459.
Linked PRs
The text was updated successfully, but these errors were encountered: