Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is failing on current main: test_asyncio.test_taskgroups #125472

Closed
Eclips4 opened this issue Oct 14, 2024 · 5 comments
Closed

CI is failing on current main: test_asyncio.test_taskgroups #125472

Eclips4 opened this issue Oct 14, 2024 · 5 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@Eclips4 Eclips4 added the type-bug An unexpected behavior, bug, or error label Oct 14, 2024
@Eclips4
Copy link
Member Author

Eclips4 commented Oct 14, 2024

Perhaps the bad commit is the d5dbbf4

@vstinner vstinner changed the title CI is failing on current main CI is failing on current main: test_asyncio.test_taskgroups Oct 14, 2024
@picnixz
Copy link
Contributor

picnixz commented Oct 14, 2024

cc @graingert

kumaraditya303 pushed a commit that referenced this issue Oct 14, 2024
…cycles (#12… (#125476)

Revert "gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959)"

This reverts commit d5dbbf4.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 14, 2024
…PyFuture refcycles (pythonGH-12… (pythonGH-125476)

Revert "pythongh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (pythonGH-124959)"

This reverts commit d5dbbf4.
(cherry picked from commit e99650b)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@1st1
Copy link
Member

1st1 commented Oct 14, 2024

Yeah, OK to revert. Weird that it did pass the GH CI.

@zware
Copy link
Member

zware commented Oct 14, 2024

Expectation is that it conflicts with a more recent change to main; the PR 124959 branch was not fully up to date before merge.

@terryjreedy
Copy link
Member

We allow PRs to be merged (if merge-compatible) with a passing GH CI for an older version of main because A) requiring a fresh green CI for every code change would drastically slow down progress and b) we have buildbots retesting all recent merges together. A coredev considering merging a PR with an 'old' green CI can trigger a retest by updating the patch, which is now easy right on the PR, and set automerge upon success.

graingert added a commit to graingert/cpython that referenced this issue Oct 14, 2024
1st1 pushed a commit that referenced this issue Oct 14, 2024
…p and _PyFuture refcycles ... (#125486)

* Revert "gh-125472: Revert "gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#12… (#125476)"

This reverts commit e99650b.

* fix incompatability with gh-124392
@zware zware closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

5 participants