Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenSSL 3.4 #127330

Closed
encukou opened this issue Nov 27, 2024 · 2 comments
Closed

Add support for OpenSSL 3.4 #127330

encukou opened this issue Nov 27, 2024 · 2 comments
Labels
extension-modules C modules in the Modules dir topic-SSL type-feature A feature request or enhancement

Comments

@encukou
Copy link
Member

encukou commented Nov 27, 2024

Feature or enhancement

OpenSSL 3.4 is out and it needs:

  • new error information
  • adding to multissltests

I plan to document what I learned about the process in make_ssl_data.py and point to that from all the places that need changing.

Linked PRs

@encukou encukou added type-feature A feature request or enhancement extension-modules C modules in the Modules dir topic-SSL labels Nov 27, 2024
encukou added a commit that referenced this issue Nov 28, 2024
…ss (GH-127331)

- Add `git describe` output to headers generated by `make_ssl_data.py`

  This info is more important than the date when the file was generated.
  It does mean that the tool now requires a Git checkout of OpenSSL,
  not for example a release tarball.

- Regenerate the older file to add the info.
  To the other older file, add a note about manual edits.

- Add notes on how to add a new OpenSSL version

- Add 3.4 error messages and multissl tests
@asvetlov
Copy link
Contributor

@encukou Is the issue complete?
Could we close it?

@encukou
Copy link
Member Author

encukou commented Dec 13, 2024

Yes, thank you for the follow-up.

@encukou encukou closed this as completed Dec 13, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
… process (pythonGH-127331)

- Add `git describe` output to headers generated by `make_ssl_data.py`

  This info is more important than the date when the file was generated.
  It does mean that the tool now requires a Git checkout of OpenSSL,
  not for example a release tarball.

- Regenerate the older file to add the info.
  To the other older file, add a note about manual edits.

- Add notes on how to add a new OpenSSL version

- Add 3.4 error messages and multissl tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension-modules C modules in the Modules dir topic-SSL type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants