Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop --wasi preview2 from wasi.py #127652

Closed
brettcannon opened this issue Dec 5, 2024 · 3 comments
Closed

Drop --wasi preview2 from wasi.py #127652

brettcannon opened this issue Dec 5, 2024 · 3 comments
Assignees
@brettcannon
Labels
OS-wasi type-feature A feature request or enhancement

Comments

@brettcannon
Copy link
Member

brettcannon commented Dec 5, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Need to remove

cpython/Tools/wasm/wasi.py

Lines 300 to 301 in 23f2e8f

# Use WASI 0.2 primitives.
"--wasi preview2 "

as we only officially support preview1.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Other

Linked PRs
@brettcannon brettcannon added 3.13 bugs and security fixes 3.14 new features, bugs and security fixes OS-wasi type-bug An unexpected behavior, bug, or error labels Dec 5, 2024
@rruuaanng
Copy link
Contributor

Do we need to fix it to --wasi preview1?, or just remove it --wasi preview2.

@bedevere-app bedevere-app bot mentioned this issue Dec 6, 2024
Merged
@brettcannon brettcannon self-assigned this Dec 6, 2024
brettcannon added a commit to brettcannon/cpython that referenced this issue Dec 6, 2024
@brettcannon
pythonGH-127652: stop using --wasi preview2 in wasi.py
6204285 
It's only to use WASI 0.2 code to back preview1 APIs and is considered experimental anyway.
@brettcannon
Copy link
Member Author

Do we need to fix it to --wasi preview1?, or just remove it --wasi preview2.

There is no --wasi preview1 flag; this is just to remove the flag as it's not necessary and is technically experimental (see the PR I just posted).

brettcannon added a commit that referenced this issue Dec 6, 2024
@brettcannon
GH-127652: stop using --wasi preview2 in wasi.py (GH-127704)
0fc4063 
It's only to use WASI 0.2 code to back preview1 APIs and is considered experimental anyway.
@brettcannon
Copy link
Member Author

The automatic backport to 3.13 failed, but since this is an optional change I'm not going to worry about it.

@picnixz picnixz added type-feature A feature request or enhancement and removed type-bug An unexpected behavior, bug, or error 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Dec 7, 2024
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@brettcannon @srinivasreddy
pythonGH-127652: stop using --wasi preview2 in wasi.py (pythonGH-…
991ab48 
…127704)

It's only to use WASI 0.2 code to back preview1 APIs and is considered experimental anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettcannon brettcannon

Labels
OS-wasi type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettcannon @picnixz @rruuaanng