Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 594 Removing dead batteries from stdlib #86777

Closed
aeros opened this issue Dec 10, 2020 · 7 comments
Closed

PEP 594 Removing dead batteries from stdlib #86777

aeros opened this issue Dec 10, 2020 · 7 comments
Labels
3.13 bugs and security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@aeros
Copy link
Contributor

aeros commented Dec 10, 2020

BPO 42611
Nosy @terryjreedy, @tiran, @jkloth, @isidentical, @aeros
PRs
  • bpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlib #23728
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-12-10.04:51:12.046>
    labels = ['type-feature', 'library', '3.10']
    title = 'PEP 594 Removing dead batteries from stdlib'
    updated_at = <Date 2020-12-12.01:54:23.481>
    user = 'https://github.com/aeros'

    bugs.python.org fields:

    activity = <Date 2020-12-12.01:54:23.481>
    actor = 'terry.reedy'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2020-12-10.04:51:12.046>
    creator = 'aeros'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 42611
    keywords = []
    message_count = 2.0
    messages = ['382815', '382898']
    nosy_count = 5.0
    nosy_names = ['terry.reedy', 'christian.heimes', 'jkloth', 'BTaskaya', 'aeros']
    pr_nums = ['23728']
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue42611'
    versions = ['Python 3.10']

    @aeros
    Copy link
    Contributor Author

    aeros commented Dec 10, 2020

    This issue was created for the purpose of tracking any changes related to PEP-594 (Removing dead batteries from stdlib), and any relevant discussions about the modules being removed.

    @aeros aeros added 3.10 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Dec 10, 2020
    @terryjreedy
    Copy link
    Member

    Until a pep is approved, discussion of its ideas belong elsewhere; an issue is only needed for a proposed implementation Is PR 23728 purely for discussion leading to possible approval of the PEP, or for merging regardless of the PEP fate?

    @terryjreedy terryjreedy changed the title PEP 594 PEP 594 Removing dead batteries from stdlib Dec 12, 2020
    @terryjreedy terryjreedy changed the title PEP 594 PEP 594 Removing dead batteries from stdlib Dec 12, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @arhadthedev
    Copy link
    Member

    Repurposing this issue for 3.13.

    @arhadthedev arhadthedev added 3.13 bugs and security fixes and removed 3.10 only security fixes labels May 12, 2023
    @hugovk
    Copy link
    Member

    hugovk commented May 21, 2023

    I've made a start on removing the more straightforward ones in a branch.

    Would it be better with all in one PR, as one PR per module, or somewhere in the middle with smaller batches?

    @arhadthedev
    Copy link
    Member

    I would vote for the one PR per module option. It allows reviewers to not get lost with each removed module having:

    • Python code
    • tests
    • documentation
    • probably a C module
      • associated automake/Makefile and Visual Studio rules
      • also we need to check for _Py* functions added exclusively for the module and used nowhere else.

    @arhadthedev
    Copy link
    Member

    Closing in favor of gh-104773.

    @CAM-Gerlach
    Copy link
    Member

    Re-closing with the correct close state.

    @CAM-Gerlach CAM-Gerlach closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.13 bugs and security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    5 participants