Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlib #23728

Closed
wants to merge 5 commits into from

Conversation

aeros
Copy link
Contributor

@aeros aeros commented Dec 10, 2020

As per PEP 594, this PR removes asyncore, asynchat, and smptd. This includes any documentation, tests, and source code, except for parts that were needed for existing tests. Those were moved to Lib/test/support/<module>, and the essential parts were determined through usage of coverage.py. After I removed test_<module>, I looked to see which members were utilized in the existing tests, and removed any that were not used. I did not do any partial removals though; e.g. specific unused branches within a member that is otherwise used. I also left unused __repr__ for debugging purposes.

For improved communication and convenience to users, importing any of the 3 removed modules after these changes results in the following:

raise ImportError(
    "As of 3.10, <module> has been removed from the standard library, see "
    "PEP 594 for details. An archived (no longer maintained) version exists "
    "at https://github.com/tiran/legacylib"
)

This could potentially be removed in couple versions if needed, but since it imposes no real maintenance burden I think we can leave the custom ImportError indefinitely. The only change would possibly be updating tiran/legacylib to python/legacylib, assuming it is eventually moved there.

https://bugs.python.org/issue42611

@aeros aeros requested a review from tiran December 10, 2020 04:40
@aeros aeros changed the title PEP 594 - Remove asyncore, asynchat, and smptd from stdlib bpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlib Dec 10, 2020
@aeros aeros removed the skip issue label Dec 10, 2020
@aeros aeros marked this pull request as ready for review December 10, 2020 05:52
@aeros aeros requested review from vsajip and a team as code owners December 10, 2020 05:52
@aeros aeros removed request for a team and vsajip December 10, 2020 06:22
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 18, 2021
@tiran tiran removed their request for review December 7, 2021 12:07
@hugovk
Copy link
Member

hugovk commented Apr 11, 2022

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 2, 2022
@iritkatriel
Copy link
Member

Closing as out of date.

This PR was superseded by #72719 (which was reverted and will not be superseded by yet a new one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants