Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document sqlite3.PrepareProtocol #94321

Closed
erlend-aasland opened this issue Jun 27, 2022 · 1 comment · Fixed by #94620
Closed

Document sqlite3.PrepareProtocol #94321

erlend-aasland opened this issue Jun 27, 2022 · 1 comment · Fixed by #94620
Assignees
@erlend-aasland
Labels
docs Documentation in the Doc dir topic-sqlite3

Comments

@erlend-aasland
Copy link
Contributor

This class is not documented, as mentioned by CAM in #93095 (comment).

Quick'n dirty description:
The sqlite3 module implements all or parts of the rejected PEP-246[^1]. PrepareProtocol serves a kind of an identifier for the __conform__ method. It also serves to form the keys of the sqlite3.adapters dict in the form of (class, PrepareProtocol) tuples.

[^1] I didn't read the PEP, so I don't know how well sqlite3 aligns with the PEP
@erlend-aasland erlend-aasland added topic-sqlite3 docs Documentation in the Doc dir labels Jun 27, 2022
@erlend-aasland erlend-aasland self-assigned this Jun 27, 2022
@erlend-aasland erlend-aasland mentioned this issue Jun 27, 2022
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jul 6, 2022
@erlend-aasland
pythongh-94321: Document sqlite3.PrepareProtocol
7ad6f24
@bedevere-bot bedevere-bot mentioned this issue Jul 6, 2022
Merged
@erlend-aasland erlend-aasland linked a pull request Jul 6, 2022 that will close this issue
gh-94321: Document sqlite3.PrepareProtocol #94620
Merged
@erlend-aasland erlend-aasland moved this from TODO: Docs to In Progress in sqlite3 issues Jul 7, 2022
Repository owner moved this from In Progress to Done in sqlite3 issues Jul 7, 2022
erlend-aasland added a commit that referenced this issue Jul 7, 2022
@erlend-aasland
gh-94321: Document sqlite3.PrepareProtocol (#94620)
fb6dcca
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 7, 2022
@erlend-aasland @miss-islington
pythongh-94321: Document sqlite3.PrepareProtocol (pythonGH-94620)
41166c7 
(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot mentioned this issue Jul 7, 2022
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jul 7, 2022
@erlend-aasland
[3.10] pythongh-94321: Document sqlite3.PrepareProtocol (pythonGH-94620…
d168606 
…).

(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot mentioned this issue Jul 7, 2022
Merged
@erlend-aasland
Copy link
Contributor Author

Fixed in:

miss-islington added a commit that referenced this issue Jul 7, 2022
@miss-islington @erlend-aasland
gh-94321: Document sqlite3.PrepareProtocol (GH-94620)
c72001e 
(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this issue Jul 7, 2022
@erlend-aasland
[3.10] gh-94321: Document sqlite3.PrepareProtocol (GH-94620) (#94671)
797745e 
(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland mentioned this issue Jul 27, 2022
Closed
5 tasks
@CAM-Gerlach CAM-Gerlach mentioned this issue Aug 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
docs Documentation in the Doc dir topic-sqlite3
Projects
sqlite3 issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-94321: Document sqlite3.PrepareProtocol erlend-aasland/cpython
1 participant
@erlend-aasland