Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100540: Remove unused Modules/_ctypes/libffi_osx/ #100543

Merged
merged 1 commit into from
Dec 28, 2022
Merged

gh-100540: Remove unused Modules/_ctypes/libffi_osx/ #100543

merged 1 commit into from
Dec 28, 2022

Conversation

zware
Copy link
Member

@zware zware commented Dec 26, 2022 •
edited by bedevere-bot
Loading

It was an ancient, modified copy of libffi that has not been in use
since GH-22855.

@zware
pythongh-100540: Remove unused Modules/_ctypes/libffi_osx/
ad202d7 
It was an ancient, modified copy of libffi that has not been in use
since pythonGH-22855.
@zware zware added 3.12 bugs and security fixes OS-mac build The build process and cross-build topic-ctypes extension-modules C modules in the Modules dir skip news labels Dec 26, 2022
@zware zware self-assigned this Dec 26, 2022
@zware zware requested a review from a team December 26, 2022 21:29
@bedevere-bot bedevere-bot mentioned this pull request Dec 26, 2022
Closed
@zware
Copy link
Member Author

zware commented Dec 26, 2022

The Azure Pipelines failure is due to patchcheck wanting to destroy the tsv values in Tools/c-analyzer/cpython/_parser.py since a mention of libffi_osx was removed from it.

@zware
Copy link
Member Author

zware commented Dec 26, 2022

!buildbot .*mac

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zware for commit ad202d7 🤖

The command will test the builders whose names match following regular expression: .*mac

The builders matched are:

  • ARM64 macOS PR
  • x86-64 macOS PR

@zware zware mentioned this pull request Dec 27, 2022
Merged
@zware zware merged commit 025b5c3 into python:main Dec 28, 2022
@zware zware deleted the remove_libffi_osx branch December 28, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

@zware zware

Labels
3.12 bugs and security fixes build The build process and cross-build extension-modules C modules in the Modules dir OS-mac skip news topic-ctypes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zware @bedevere-bot @erlend-aasland