-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-97930: Apply changes from importlib_resources 5.10. #100598
Conversation
362c36c
to
a2524ba
Compare
95e3e1d
to
0b49678
Compare
…eing preferred and Package object being deprecated.
0b49678
to
81c3c5e
Compare
|
The buildbot failure appears unrelated to this change and highly isolated, so I'm going to assume it's a spurious failure. |
this version was in the recent 0.21.0 release and worked fine the irc library is broken (for us) since jaraco/irc@c95c063 the reason is that it uses importlib.resources.files() to import codes and this function is buggy -- it doesn't work with freezed code (see also python/cpython#121735. wimglenn/resources-example#6) and (what a coincidence!) broken implementation of files() function was written by the same person -- see python/cpython#100598
Previous sync with 5.9 was #97929.
Changes are described here:
These changes have been released for several months with no reported concerns.