Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] Bump Azure Pipelines to ubuntu-20.04 #100854

Closed
wants to merge 3 commits into from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 8, 2023

The 3.7 branch builds on Azure Pipelines is failing, for example:

##[warning]An image label with the label ubuntu-16.04 does not exist.
,##[error]The remote provider was unable to process the request.

The main and 3.11-3.8 branches were already bumped to ubuntu-20.04 by #89170, which didn't make it back to 3.7.


Alternatively, we could use ubuntu-22.04 for all branches, or the ubuntu-latest alias which is now pointing to ubuntu-22.04.

@hugovk hugovk force-pushed the 3.7-azure-pipelines-ubuntu-20.04 branch from b269d75 to 2b05fd9 Compare January 8, 2023 15:57
@hugovk
Copy link
Member Author

hugovk commented Jan 8, 2023

Also included #21776 to move the triggers into the YAML files, which was backported down to 3.8, but not 3.7.

@zooba Do you know why this PR isn't triggering on Azure Pipelines?

@zooba
Copy link
Member

zooba commented Jan 9, 2023

The PR trigger is overridden to only run on PRs to main, to avoid slowing down backports. And there's a separate build definition for CI builds (using the same YAML, and the default triggers for CI). I'm pretty sure triggers are only evaluated from the default branch's YAML, which is probably main.

Updating the OS images seems fine. I'd prefer to have it explicitly select an Ubuntu version - using latest is unfortunately asking for random warnings that may cause the build to look like a failure,though it is handy to get early notification of failures on the next OS... no way to win, unfortunately, but I'd rather not get the "about to change -latest" warnings here I think.

@hugovk
Copy link
Member Author

hugovk commented Jan 16, 2023

Please see PR #101089 to replace this one.

@hugovk hugovk deleted the 3.7-azure-pipelines-ubuntu-20.04 branch January 21, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants