Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101277: Isolate itertools, part 2/4 #101303

Merged
merged 7 commits into from
Feb 3, 2023
Merged

gh-101277: Isolate itertools, part 2/4 #101303

merged 7 commits into from
Feb 3, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 24, 2023 •
edited by bedevere-bot
Loading

Add dropwhile, takewhile, starmap, combinations*, and permutations types to module state

@bedevere-bot bedevere-bot mentioned this pull request Jan 24, 2023
Closed
@erlend-aasland erlend-aasland force-pushed the isolate-itertools/batch-2 branch from 8a063a7 to 2373926 Compare January 25, 2023 08:57
@erlend-aasland erlend-aasland mentioned this pull request Feb 1, 2023
Merged
@erlend-aasland erlend-aasland force-pushed the isolate-itertools/batch-2 branch from 2373926 to 29a3485 Compare February 1, 2023 11:54
@erlend-aasland erlend-aasland marked this pull request as ready for review February 1, 2023 11:56
@corona10 corona10 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 1, 2023
@corona10 corona10 self-requested a review February 1, 2023 12:25
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 29a3485 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 1, 2023
corona10
corona10 approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@kumaraditya303 kumaraditya303 merged commit a52cc98 into python:main Feb 3, 2023
@kumaraditya303
Copy link
Contributor

Thanks @erlend-aasland, onto the next one!

iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Feb 3, 2023
@erlend-aasland @iritkatriel
pythongh-101277: Port more itertools static types to heap types (py…
fef6510 
…thon#101303)

Add dropwhile, takewhile, starmap, combinations*, and permutations types to module state.
@erlend-aasland
Copy link
Contributor Author

Thanks @erlend-aasland, onto the next one!

Thanks, Kumar! I'm on the road these days; I'll try to find the time to prepare part 3 later today.

@erlend-aasland erlend-aasland deleted the isolate-itertools/batch-2 branch February 3, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@corona10 corona10 corona10 approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @bedevere-bot @kumaraditya303 @corona10