-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-98831: Modernize FORMAT_VALUE #101628
gh-98831: Modernize FORMAT_VALUE #101628
Conversation
d4ba909
to
1e48f9d
Compare
This wasn't simple after all. A test crashed because there was an error path with a manual While I think I've fixed this now, this points out a general weakness in our bytecode definitions. Sometimes we feel forced to leave a manual |
🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit 1e48f9d 🤖 If you want to schedule another build, you need to add the |
Ready for review. |
This is blocked until I can figure out the refleak failures. (EDIT: But first I'm going to re-run that particular build, in case it's a flake.) |
Hm, aarch64 RHEL8 Refleaks PR seems to have been failing a lot, historically. Ignoring. |
This was the simplest one I've done in a while, except that I had to fix the DSL parser to support balanced parentheses and brackets in conditions (and array sizes, as a side benefit).