Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101747: Fix refleak in new OrderedDict repr #101748

Merged
merged 2 commits into from
Feb 10, 2023
Merged

gh-101747: Fix refleak in new OrderedDict repr #101748

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8adfe9
gh-101747: Fix refleak in new `OrderedDict` repr
sobolevn Feb 9, 2023
dce3ec1
Apply code review suggestion
sobolevn Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Objects/odictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1388,6 +1388,7 @@ odict_repr(PyODictObject *self)

Done:
Py_ReprLeave((PyObject *)self);
Py_XDECREF(dcopy);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can move it above the Done label and change Py_XDECREF to Py_DECREF.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it might be a slightly more readable! I will wait for all tests to finish and apply it :)

return result;
}

Expand Down