-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-102013: Add PyUnstable_GC_VisitObjects #102014
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c4a91e0
Add PyGC_VisitObjects
jbower-fb 57edf6d
📜🤖 Added by blurb_it.
blurb-it[bot] 447bb53
Remove from Limited API
jbower-fb d4f9505
Merge branch 'main' into gcvisitobjs
hauntsaninja d34a900
Updated to "unstable" API, protect against GC and current object dele…
jbower-fb 7c1fbbb
Merge branch 'gcvisitobjs' of https://github.com/jbower-fb/cpython-jb…
jbower-fb 9b0c461
Fix formatting in Modules/_testcapimodule.c
jbower-fb 29f7f88
Fix formatting in Modules/_testcapimodule.c
jbower-fb e16f1e3
Fix formatting in Modules/_testcapimodule.c
jbower-fb 024ee30
Fix formatting in Modules/_testcapimodule.c
jbower-fb bd65abb
Fix formatting in Modules/gcmodule.c
jbower-fb f03e581
Fix formatting in Modules/gcmodule.c
jbower-fb 16ea0d6
Fix formatting in Modules/gcmodule.c
jbower-fb 369e199
Simplify test in Modules/_testcapimodule.c
jbower-fb 219154a
Address minor review comments and add documentation.
jbower-fb be5b7f0
Merge branch 'main' into gcvisitobjs
jbower-fb 5752f1c
Update Doc/c-api/gcsupport.rst
jbower-fb 1512004
Update Modules/_testcapimodule.c
jbower-fb 87a5b56
Update Modules/_testcapimodule.c
jbower-fb 295f7dd
Minor doc tweaks from review
jbower-fb ed06dff
Merge branch 'python:main' into gcvisitobjs
jbower-fb 620043b
Merge branch 'main' into gcvisitobjs
jbower-fb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/C API/2023-02-18-00-55-14.gh-issue-102013.83mrtI.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add a new (unstable) C-API function for iterating over GC'able objects using a callback: ``PyUnstable_VisitObjects``. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put this in
Include/cpython/objimpl.h
, which is only included for non-limited API. But that's not a blocker.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with the conventions here, is that what we should do with public API (even if it's unstable)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Details are in the Devguide.