Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102103: add module argument to dataclasses.make_dataclass #102104

Merged
merged 4 commits into from
Mar 11, 2023
Merged

gh-102103: add module argument to dataclasses.make_dataclass #102104

merged 4 commits into from
Mar 11, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 21, 2023 •
edited by bedevere-bot
Loading

Now, dataclasses created by this function are also pickleable (as a side effect of fixing __module__ attribute).

@sobolevn sobolevn requested a review from ericvsmith as a code owner February 21, 2023 08:57
@bedevere-bot bedevere-bot mentioned this pull request Feb 21, 2023
Closed
carljm
carljm reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a real issue, and solving it in the same way as namedtuple seems reasonable (though it's too bad to add more stack-walking.)

Lib/test/test_dataclasses.py Outdated Show resolved Hide resolved
Lib/test/test_dataclasses.py Show resolved Hide resolved
@sobolevn @carljm
Update Lib/test/test_dataclasses.py
7a77839 
Co-authored-by: Carl Meyer <carl@oddbird.net>
@sobolevn
Copy link
Member Author

sobolevn commented Mar 8, 2023

@ericvsmith friendly ping :)

@carljm carljm merged commit b48be8f into python:main Mar 11, 2023
@sobolevn
Copy link
Member Author

Thanks!

iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Mar 12, 2023
@sobolevn @iritkatriel
pythongh-102103: add module argument to dataclasses.make_dataclass (
cdf9e3a 
python#102104)
@sobolevn sobolevn mentioned this pull request Mar 20, 2023
Closed
@remilapeyre remilapeyre mentioned this pull request Apr 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @carljm @bedevere-bot