Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-74690: Add more tests for runtime-checkable protocols #103347

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Apr 7, 2023

This PR adds more tests for runtime-checkable protocols, ensuring various edge cases are covered. Some of the invariants I'm adding tests for would have been broken by some more hare-brained optimisations that we considered, but rejected, in #74690 and #103310.

@AlexWaygood AlexWaygood merged commit 800382a into python:main Apr 7, 2023
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@AlexWaygood AlexWaygood deleted the more-runtime-protocol-tests branch April 7, 2023 17:21
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 7, 2023
…nGH-103347)

(cherry picked from commit 800382a)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

GH-103350 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 7, 2023
miss-islington added a commit that referenced this pull request Apr 7, 2023
(cherry picked from commit 800382a)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir topic-typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants