gh-83004: Harden winreg init #103386
Merged
gh-83004: Harden winreg init #103386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erlend-aasland
commented
Apr 8, 2023
•
erlend-aasland
commented
- Issue: Improve stdlib module initialization error handling. #83004
erlend-aasland
force-pushed
the
cleanup-winreg
branch
from
2c298f2 to
e664a52
Compare
|
@zooba, I'm landing this later tonight. |
aisk
reviewed
Apr 11, 2023
| @@ -2170,7 +2172,14 @@ PyMODINIT_FUNC PyInit_winreg(void) | |||
| ADD_INT(REG_RESOURCE_LIST); | |||
| ADD_INT(REG_FULL_RESOURCE_DESCRIPTOR); | |||
| ADD_INT(REG_RESOURCE_REQUIREMENTS_LIST); | |||
|
|
|||
| #undef ADD_INT | |||
There was a problem hiding this comment.
Should we undef the ADD_KEY here also?
There was a problem hiding this comment.
Yes ideally, but not worth a separate PR, IMO.
There was a problem hiding this comment.
Trying to merge this to #103250 , I'll add it is this PR.
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.