Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-103963: Make dis display names of args for intrinsics opcodes #104029

Merged
merged 15 commits into from
May 3, 2023
Merged

GH-103963: Make dis display names of args for intrinsics opcodes #104029

merged 15 commits into from
May 3, 2023

Conversation

jkchandalia
Copy link
Contributor

@jkchandalia jkchandalia commented May 1, 2023 •
edited by bedevere-bot
Loading

Make the dis module display the names of the args for opcodes CALL_INTRINSIC_*.

Fixes #103963

@bedevere-bot bedevere-bot mentioned this pull request May 1, 2023
Closed
@jkchandalia
Copy link
Contributor Author

FYI @iritkatriel @nanjekyejoannah @JelleZijlstra

JelleZijlstra
JelleZijlstra reviewed May 1, 2023
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few comments. You'll also have to add a NEWS entry.

Lib/test/test_dis.py Outdated Show resolved Hide resolved
Tools/build/generate_opcode_h.py Outdated Show resolved Hide resolved
@jkchandalia
Copy link
Contributor Author

@iritkatriel @JelleZijlstra I've reviewed your comments and updated the PR. Please let me know if you see anything else or if I should convert to normal PR.

JelleZijlstra
JelleZijlstra reviewed May 2, 2023
View reviewed changes
Lib/test/test_dis.py Outdated Show resolved Hide resolved
JelleZijlstra
JelleZijlstra approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@JelleZijlstra
Copy link
Member

I'll give Irit some time to take another look, but I think this is ready to merge.

@hugovk hugovk mentioned this pull request May 2, 2023
Closed
iritkatriel
iritkatriel reviewed May 2, 2023
View reviewed changes
Include/internal/pycore_intrinsics.h Outdated


/* Binary Functions: */
#define INTRINSIC_INVALID 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like INTRINSIC_INVALID is defined twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to differentiate between invalid for the two CALL_INTRINSIC_* opcodes.

@iritkatriel iritkatriel marked this pull request as ready for review May 2, 2023 17:46
@JelleZijlstra JelleZijlstra merged commit 872cbc6 into python:main May 3, 2023
@erlend-aasland erlend-aasland mentioned this pull request May 3, 2023
Merged
@carljm carljm mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dis: Show names of intrinsics
4 participants
@jkchandalia @JelleZijlstra @iritkatriel @bedevere-bot