Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30064: Refactor sock_* asyncio API #10419

Merged
merged 11 commits into from
Nov 12, 2018
Merged

bpo-30064: Refactor sock_* asyncio API #10419

merged 11 commits into from
Nov 12, 2018
+167 −446

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Nov 8, 2018 •
edited by bedevere-bot
Loading

Use add_done_callback() to unsubscribe reader/writer early on calcellation.

https://bugs.python.org/issue30064

@asvetlov asvetlov requested a review from 1st1 as a code owner November 8, 2018 22:41
@asvetlov asvetlov changed the title [WIP] bpo-30064: Refactor sock_* asyncio API bpo-30064: Refactor sock_* asyncio API Nov 8, 2018
@asvetlov
Copy link
Contributor Author

asvetlov commented Nov 8, 2018

@1st1 please review

1st1
1st1 approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice step forward but we also need to start using socket._io_refs to prevent sockets from being removed during IO.

@asvetlov
Copy link
Contributor Author

I'll do it in the following PR.
Wanted to fix one issue at once.

@asvetlov asvetlov merged commit 7438792 into python:master Nov 12, 2018
@bedevere-bot
Copy link

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@asvetlov asvetlov deleted the issue-30064 branch November 12, 2018 17:00
fantix added a commit to fantix/uvloop that referenced this pull request Feb 8, 2021
@fantix
Fix future issue in sock_connect()
1f8fdba 
CPython fixed the same issue in python/cpython#10419. Seems like under
pressure, more write callbacks may happen before _remove_writer() is
called, so we should check for done().

Fixes MagicStack#378
@fantix fantix mentioned this pull request Feb 8, 2021
Closed
fantix added a commit to fantix/uvloop that referenced this pull request Feb 9, 2021
@fantix
Fix future issue in sock_connect()
0360dab 
CPython fixed the same issue in python/cpython#10419. Seems like under
pressure, more write callbacks may happen before _remove_writer() is
called, so we should check for done().

Fixes MagicStack#378
@abacabadabacaba abacabadabacaba mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asvetlov @bedevere-bot @1st1 @the-knights-who-say-ni