Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

howto/urllib2: remove link to an outdated french translation #104193

Merged
merged 1 commit into from
May 22, 2023
Merged

howto/urllib2: remove link to an outdated french translation #104193

merged 1 commit into from
May 22, 2023

Conversation

deronnax
Copy link
Contributor

@deronnax deronnax commented May 5, 2023 •
edited by github-actions bot
Loading

We now have our own translation and it's not outdated.

ping @JulienPalard (we work together on the French translation)

📚 Documentation preview 📚: https://cpython-previews--104193.org.readthedocs.build/

@deronnax
howto/urllib2: remove link to an outdated french translation
7fa927e 
We now have our own translation and it's not outdated
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels May 5, 2023
@deronnax
Copy link
Contributor Author

deronnax commented May 5, 2023

Also Julien, what's your opinion on removing altogether the urllib2 howto page? It's full of dated concepts and outdated links, and I am worried it would lure some fwely knowledgeable developers to use urlllib2. If you agree, I will open an PR to propose the removal (with lengthy arguments on why)

@JulienPalard JulienPalard added the needs backport to 3.11 only security fixes label May 22, 2023
@JulienPalard JulienPalard merged commit 151b6bf into python:main May 22, 2023
@miss-islington
Copy link
Contributor

Thanks @deronnax for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-104746 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2023
@deronnax @miss-islington
howto/urllib2: remove link to an outdated french translation (pythonG…
43bd0f7 
…H-104193)

We now have our own translation and it's not outdated
(cherry picked from commit 151b6bf)

Co-authored-by: Mathieu Dupuy <deronnax@gmail.com>
@JulienPalard
Copy link
Member

For howto/urllib2 I don't think it should be deleted. Maybe enhanced and renamed to urllib (with a proper redirection configured server-side).

JulienPalard pushed a commit that referenced this pull request May 22, 2023
@miss-islington @deronnax
[3.11] howto/urllib2: remove link to an outdated french translation (G…
be20e9c 
…H-104193) (GH-104746)

howto/urllib2: remove link to an outdated french translation (GH-104193)

We now have our own translation and it's not outdated
(cherry picked from commit 151b6bf)

Co-authored-by: Mathieu Dupuy <deronnax@gmail.com>
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 bug and security fixes label May 22, 2023
@miss-islington
Copy link
Contributor

Thanks @deronnax for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-104758 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2023
@deronnax @miss-islington
howto/urllib2: remove link to an outdated french translation (pythonG…
006e525 
…H-104193)

We now have our own translation and it's not outdated
(cherry picked from commit 151b6bf)

Co-authored-by: Mathieu Dupuy <deronnax@gmail.com>
JelleZijlstra pushed a commit that referenced this pull request May 23, 2023
@miss-islington @deronnax
[3.12] howto/urllib2: remove link to an outdated french translation (G…
25b5ce7 
…H-104193) (#104758)

We now have our own translation and it's not outdated
(cherry picked from commit 151b6bf)

Co-authored-by: Mathieu Dupuy <deronnax@gmail.com>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deronnax @miss-islington @bedevere-bot @JulienPalard @JelleZijlstra @AlexWaygood