Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104484: Add parameter @case_sensitive to pathlib.PurePath.match() function #104565

Merged
merged 11 commits into from
May 18, 2023
Merged

gh-104484: Add parameter @case_sensitive to pathlib.PurePath.match() function #104565

merged 11 commits into from
May 18, 2023

Conversation

thirumurugan-git
Copy link
Contributor

@thirumurugan-git thirumurugan-git commented May 16, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 16, 2023
Closed
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 16, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@barneygale
Copy link
Contributor

Thanks for looking at this! The default value of case_sensitive should be None, which means "use platform-specific rules", i.e. case-sensitive on Posix and case-insensitive on Windows. See the implementation in glob().

Could you also add tests please? I think they'll show that your current patch doesn't enable case-sensitive matching on Windows, because the implementation is still working with the case-normalized parts.

barneygale
barneygale requested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better! Could you also document the new argument in pathlib.rst? Thanks!

Lib/test/test_pathlib.py Outdated Show resolved Hide resolved
Lib/test/test_pathlib.py Outdated Show resolved Hide resolved
Lib/pathlib.py Outdated Show resolved Hide resolved
Lib/pathlib.py Outdated Show resolved Hide resolved
Lib/pathlib.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@thirumurugan-git
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@barneygale: please review the changes made to this pull request.

barneygale
barneygale requested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Pretty close now. Could you add an entry to the 3.12 "What's New" document? Apparently I forgot to add a paragraph there for the addition of case_sensitive to glob() and rglob() - if you could mention all three in a single bullet point I'd be much obliged!

Doc/library/pathlib.rst Outdated Show resolved Hide resolved
Lib/pathlib.py Outdated Show resolved Hide resolved
Lib/pathlib.py Outdated Show resolved Hide resolved
Lib/pathlib.py Outdated Show resolved Hide resolved
Lib/test/test_pathlib.py Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@thirumurugan-git
Copy link
Contributor Author

the requested changes; please review again.

barneygale
barneygale requested changes May 18, 2023
View reviewed changes
Doc/library/pathlib.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Lib/pathlib.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2023-05-17-03-14-07.gh-issue-104484.y6KxL6.rst Outdated Show resolved Hide resolved
thirumurugan-git and others added 3 commits May 18, 2023 07:44
@thirumurugan-git @barneygale
Update Doc/whatsnew/3.12.rst
90ed5c6 
Co-authored-by: Barney Gale <barney.gale@gmail.com>
@thirumurugan-git @barneygale
Update Misc/NEWS.d/next/Library/2023-05-17-03-14-07.gh-issue-104484.y…
563172c 
…6KxL6.rst

Co-authored-by: Barney Gale <barney.gale@gmail.com>
@thirumurugan-git @barneygale
Update Lib/pathlib.py
be06795 
Co-authored-by: Barney Gale <barney.gale@gmail.com>
@thirumurugan-git
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@barneygale: please review the changes made to this pull request.

barneygale
barneygale requested changes May 18, 2023
View reviewed changes
Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, otherwise LGTM.

Lib/pathlib.py Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@thirumurugan-git
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@barneygale: please review the changes made to this pull request.

barneygale
barneygale approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this.

@barneygale barneygale merged commit dcdc90d into python:main May 18, 2023
@barneygale barneygale mentioned this pull request May 18, 2023
Closed
carljm added a commit to carljm/cpython that referenced this pull request May 18, 2023
@carljm
Merge branch 'main' into nestedcomps
54095f0 
* main:
  pythongh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols (python#104622)
  pythongh-104623: Update Windows installer to use SQLite 3.42.0 (python#104625)
  pythongh-104050: Add more type annotations to Argument Clinic (python#104628)
  pythongh-104629: Don't skip test_clinic if _testclinic is missing (python#104630)
  pythongh-104549: Set __module__ on TypeAliasType (python#104550)
  pythongh-104050: Improve some typing around `default`s and sentinel values (python#104626)
  pythongh-104146: Remove unused vars from Argument Clinic (python#104627)
  pythongh-104615: don't make unsafe swaps in apply_static_swaps (python#104620)
  pythonGH-104484: Add case_sensitive argument to `pathlib.PurePath.match()` (pythonGH-104565)
  pythonGH-96803: Document and test new unstable internal frame API functions (pythonGH-104211)
  pythonGH-104580: Don't cache eval breaker in interpreter (pythonGH-104581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barneygale barneygale barneygale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thirumurugan-git @bedevere-bot @barneygale