Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101282: Revert some M4 style for BOLT configuration #104751

Closed
wants to merge 4 commits into from
Closed

gh-101282: Revert some M4 style for BOLT configuration #104751

wants to merge 4 commits into from

Conversation

corona10
Copy link
Member

@corona10 corona10 commented May 22, 2023 •
edited
Loading

Without this revert on macOS:

checking for --enable-bolt... no
checking BOLT_INSTRUMENT_FLAGS...
checking BOLT_APPLY_FLAGS... ./configure: line 8401: -reorder-blocks=ext-tsp: command not found

With this revert on macOS:

checking BOLT_INSTRUMENT_FLAGS...
checking BOLT_APPLY_FLAGS... -update-debug-sections -reorder-blocks=ext-tsp -reorder-functions=hfsort+ -split-functions -icf=1 -inline-all -split-eh -reorder-functions-use-hot-size -peepholes=none -jump-tables=aggressive -inline-ap -indirect-call-promotion=all -dyno-stats -use-gnu-stack -frame-opt=hot

@corona10 corona10 requested a review from erlend-aasland as a code owner May 22, 2023 15:25
@bedevere-bot bedevere-bot mentioned this pull request May 22, 2023
Closed
4 tasks
@corona10 corona10 requested a review from ned-deily May 22, 2023 15:33
ned-deily
ned-deily approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@corona10
Copy link
Member Author

@ned-deily cc @erlend-aasland

I am preparing another PR too.

@corona10
Copy link
Member Author

cc @indygreg Not decided yet which PR will be merged

@corona10 corona10 added the needs backport to 3.12 bug and security fixes label May 23, 2023
erlend-aasland
erlend-aasland requested changes May 24, 2023
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go for this variant, I'd make the list more "git diff" friendly. I left a suggestion for this.

configure.ac Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@erlend-aasland erlend-aasland mentioned this pull request May 24, 2023
Merged
corona10 and others added 2 commits May 24, 2023 16:06
@corona10 @erlend-aasland
Update configure.ac
b2abdb3 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@corona10
regen
a5812a3
erlend-aasland
erlend-aasland approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I prefer #104752

@corona10 corona10 closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@ned-deily ned-deily ned-deily approved these changes

Assignees

@Yhg1s Yhg1s

@erlend-aasland erlend-aasland

Labels
awaiting merge needs backport to 3.12 bug and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @bedevere-bot @ned-deily @erlend-aasland @Yhg1s