Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104764: Skip failing tests in test_enum that started failing. #104765

Merged
merged 1 commit into from
May 22, 2023
Merged

gh-104764: Skip failing tests in test_enum that started failing. #104765

merged 1 commit into from
May 22, 2023

Conversation

Yhg1s
Copy link
Member

@Yhg1s Yhg1s commented May 22, 2023 •
edited by bedevere-bot
Loading

Skip failing tests in test_enum that started failing when the version was bumped to 3.13.

@Yhg1s Yhg1s requested a review from ethanfurman as a code owner May 22, 2023 22:54
@bedevere-bot bedevere-bot mentioned this pull request May 22, 2023
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 22, 2023
@Eclips4
Copy link
Member

Eclips4 commented May 22, 2023

Nit: maybe use a @unittest.expectedFailure instead of bump version?

@Yhg1s
Copy link
Member Author

Yhg1s commented May 22, 2023

Nit: maybe use a @unittest.expectedFailure instead of bump version?

I don't know if they are expected, or why it wasn't using unittest.unexpectedFailure before, or what version they should be checking. I just want to get CI green after the version bump.

JelleZijlstra
JelleZijlstra approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this now to get CI green, we can adjust these tests later.

vstinner
vstinner approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But the enum maintainer may consider to change the default behavior or the tests to make it better.

@vstinner vstinner mentioned this pull request May 22, 2023
Merged
@Yhg1s Yhg1s merged commit 586aca3 into python:main May 22, 2023
@Yhg1s Yhg1s deleted the disable-failing-enum-tests branch November 22, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@vstinner vstinner vstinner approved these changes

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yhg1s @Eclips4 @vstinner @JelleZijlstra @bedevere-bot