Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104497: Make tkinter test pass with tk 8.7 #104789

Merged
merged 2 commits into from
May 27, 2023
Merged

gh-104497: Make tkinter test pass with tk 8.7 #104789

merged 2 commits into from
May 27, 2023

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented May 23, 2023 •
edited by bedevere-bot
Loading

For test_widgets.MenuTest.test_configure_type, the options in the error message change to alphabetical order.

@terryjreedy
pythongh-104497: Make tkinter test pass with tk 8.7
ff8f707 
For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.
@terryjreedy terryjreedy added tests Tests in the Lib/test dir skip news DO-NOT-MERGE needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels May 23, 2023
@terryjreedy terryjreedy self-assigned this May 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 23, 2023
Closed
@terryjreedy
Copy link
Member Author

@chrstphrchvz please verify that this passes on 8.7.

@serhiy-storchaka I presume a root.destroy call is needed rather than merely deleting the python binding. If another test in the file ever needs a fix for 8.7 or 9.0, etc., fetching tk_version could be moved to the top of the file, or I could do so now if you prefer.

@terryjreedy
Copy link
Member Author

@chrstphrchvz Please verify that this run without error on 8.7.

@serhiy-storchaka If tk_ver were someday needed for another test, it could be moved to module level. I can do so now if you want.

I presume that explicit root.destroy is needed before exiting the function.

chrstphrchvz
chrstphrchvz reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@chrstphrchvz chrstphrchvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the test passes on Tk 8.7 with this change.

Lib/test/test_tkinter/test_widgets.py Outdated Show resolved Hide resolved
Lib/test/test_tkinter/test_widgets.py Outdated Show resolved Hide resolved
serhiy-storchaka
serhiy-storchaka reviewed May 24, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use widget.info_patchlevel() in 3.11+, or test.test_tkinter.support.tcl_version or test.test_tkinter.support.get_tk_patchlevel() in older versions.

@terryjreedy @serhiy-storchaka
Update Lib/test/test_tkinter/test_widgets.py
ac16189 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@terryjreedy terryjreedy enabled auto-merge (squash) May 27, 2023 19:03
@terryjreedy
Copy link
Member Author

This PR was written specifically as it is because this was the only known test failure when written. #104855 and #104856 report more is test_widget and widget_test. I will later list the alternatives I see in the first of those issues.

@terryjreedy terryjreedy merged commit 897e716 into python:main May 27, 2023
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105028 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
@terryjreedy @serhiy-storchaka @miss-islington
pythongh-104497: Make tkinter test pass with tk 8.7 (pythonGH-104789)
3fdfdab 
* pythongh-104497: Make tkinter test pass with tk 8.7

For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.

* Update Lib/test/test_tkinter/test_widgets.py

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

---------

(cherry picked from commit 897e716)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 27, 2023
@bedevere-bot
Copy link

GH-105029 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 27, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
@terryjreedy @serhiy-storchaka @miss-islington
pythongh-104497: Make tkinter test pass with tk 8.7 (pythonGH-104789)
afe4b8d 
* pythongh-104497: Make tkinter test pass with tk 8.7

For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.

* Update Lib/test/test_tkinter/test_widgets.py

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

---------

(cherry picked from commit 897e716)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
terryjreedy added a commit that referenced this pull request May 27, 2023
@miss-islington @terryjreedy @serhiy-storchaka
[3.12] gh-104497: Make tkinter test pass with tk 8.7 (GH-104789) (#10…
5426ff1 
…5028)

For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.
---------

(cherry picked from commit 897e716)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
terryjreedy added a commit that referenced this pull request May 27, 2023
@miss-islington @terryjreedy @serhiy-storchaka
[3.11] gh-104497: Make tkinter test pass with tk 8.7 (GH-104789) (#10…
dcfa816 
…5029)

For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.
---------

(cherry picked from commit 897e716)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@terryjreedy terryjreedy deleted the tkalpha branch May 27, 2023 21:53
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrstphrchvz chrstphrchvz chrstphrchvz left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees

@terryjreedy terryjreedy

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@terryjreedy @miss-islington @bedevere-bot @serhiy-storchaka @chrstphrchvz