-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-104804: Remove webbrowser.MacOSX class, deprecated in Python 3.11 #104816
Conversation
Would not be better to split this PR on two? One for removing, and other for tidying? |
I can do, but they are intertwined: this bit is removed, which otherwise has warnings that would need fixing, or waiting for part 1 to be merged: .. deprecated-removed:: 3.11 3.13
:class:`MacOSX` is deprecated, use :class:`MacOSXOSAScript` instead. Seems easier to do both at once. But either way is fine for me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a handful of doc-related suggestions. Otherwise, the core change looks good. The removal of the :class:
syntax for things that are really code snippits (and not formally documented anyway) makes sense, as does silencing warnings for env vars not explicitly defined by or primarily/exclusively used by Python itself.
Ideally it would be nice to split it into two PRs as @serhiy-storchaka , but as a practical matter given they interlinked, maybe not worth the extra effort.
Misc/NEWS.d/next/Library/2023-05-23-21-25-54.gh-issue-104804.78fiE6.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Misc/NEWS.d/next/Library/2023-05-23-21-25-54.gh-issue-104804.78fiE6.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you fix the typo in the NEWS entry.
Closes #104804.
Remove
webbrowser.MacOSX class
, deprecated in Python 3.11 in gh-86421.Also fix Sphinx warnings in
webbrowser.rst
(helps gh-101100):I don't think we need to define
envvar
s forPATH
orKDEDIR
We could define
.. envvar:: BROWSER
right before the first mention, but it looks a little out of place having aBROWSER
before the third paragraph. Thoughts?I also don't think we need to define the dozen or so
Mozilla
,Opera
etc. classes. They're listed in the table that shows which type name corresponds to each class, and some of them have extra details like how they're instantiated (Mozilla('mozilla')
,GenericBrowser('lynx')
), so plain literal text makes sense here. Repeating each class below would be a lot of duplication for little benefit, especially for this rather short page.https://cpython-previews--104816.org.readthedocs.build/en/104816/library/webbrowser.html
📚 Documentation preview 📚: https://cpython-previews--104816.org.readthedocs.build/