Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] gh-104866: Tokenize should emit NEWLINE after exiting block with comment (GH-104870) #104872

Merged
merged 2 commits into from
May 24, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 24, 2023

(cherry picked from commit c90a862)

Co-authored-by: Lysandros Nikolaou lisandrosnik@gmail.com

…h comment (pythonGH-104870)

(cherry picked from commit c90a862)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@lysnikolaou
Copy link
Member

@pablogsal @terryjreedy test_idle fails on 3.12 with this. I haven't exactly kept up with what happened there, so it's a bit unclear what we should do about it.

@terryjreedy
Copy link
Member

Test failures at least mostly due to tokenizer - idlelib criss-crossed backports snafu. Rerunning after updating to get patch just merged.

@terryjreedy terryjreedy merged commit ddc29c8 into python:3.12 May 24, 2023
@miss-islington miss-islington deleted the backport-c90a862-3.12 branch May 24, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants